Source/core/rendering/RenderBox.cpp - Issue 259993006: Cleanup: Replace adjustForColumns() / offsetForColumns() with columnOffset().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 259993006: Cleanup: Replace adjustForColumns() / offsetForColumns() with columnOffset(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderBox.cpp

diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp

index acc271c4fcd549446803dce8dcef3a8cb28d5371..ddc564a6cd30aced7b51ef9f6dcf881dd5ae2be1 100644

--- a/Source/core/rendering/RenderBox.cpp

+++ b/Source/core/rendering/RenderBox.cpp

@@ -1877,7 +1877,7 @@ LayoutSize RenderBox::offsetFromContainer(RenderObject* o, const LayoutPoint& po

offset += toSize(columnRect.location());

LayoutPoint columnPoint = block->flipForWritingModeIncludingColumns(point + offset);

offset = toLayoutSize(block->flipForWritingModeIncludingColumns(toLayoutPoint(offset)));

- o->adjustForColumns(offset, columnPoint);

+ offset += o->columnOffset(columnPoint);

offset = block->flipForWritingMode(offset);

if (offsetDependsOnPoint)

« no previous file with comments | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderBoxModelObject.cpp » ('j') | no next file with comments »