Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects.h

Issue 259993004: Fix and cleanup Map::GeneralizeRepresentation(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix representation check on target map. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3423 matching lines...) Expand 10 before | Expand all | Expand 10 after
3434 // Accessor for complete descriptor. 3434 // Accessor for complete descriptor.
3435 inline void Get(int descriptor_number, Descriptor* desc); 3435 inline void Get(int descriptor_number, Descriptor* desc);
3436 inline void Set(int descriptor_number, Descriptor* desc); 3436 inline void Set(int descriptor_number, Descriptor* desc);
3437 void Replace(int descriptor_number, Descriptor* descriptor); 3437 void Replace(int descriptor_number, Descriptor* descriptor);
3438 3438
3439 // Append automatically sets the enumeration index. This should only be used 3439 // Append automatically sets the enumeration index. This should only be used
3440 // to add descriptors in bulk at the end, followed by sorting the descriptor 3440 // to add descriptors in bulk at the end, followed by sorting the descriptor
3441 // array. 3441 // array.
3442 inline void Append(Descriptor* desc); 3442 inline void Append(Descriptor* desc);
3443 3443
3444 static Handle<DescriptorArray> Merge(Handle<Map> left_map,
3445 int verbatim,
3446 int valid,
3447 int new_size,
3448 int modify_index,
3449 StoreMode store_mode,
3450 Handle<Map> right_map)
3451 V8_WARN_UNUSED_RESULT;
3452
3453 bool IsMoreGeneralThan(int verbatim,
3454 int valid,
3455 int new_size,
3456 DescriptorArray* other);
3457
3458 static Handle<DescriptorArray> CopyUpTo(Handle<DescriptorArray> desc, 3444 static Handle<DescriptorArray> CopyUpTo(Handle<DescriptorArray> desc,
3459 int enumeration_index, 3445 int enumeration_index,
3460 int slack = 0); 3446 int slack = 0);
3461 3447
3462 static Handle<DescriptorArray> CopyUpToAddAttributes( 3448 static Handle<DescriptorArray> CopyUpToAddAttributes(
3463 Handle<DescriptorArray> desc, 3449 Handle<DescriptorArray> desc,
3464 int enumeration_index, 3450 int enumeration_index,
3465 PropertyAttributes attributes, 3451 PropertyAttributes attributes,
3466 int slack = 0); 3452 int slack = 0);
3467 3453
(...skipping 3258 matching lines...) Expand 10 before | Expand all | Expand 10 after
6726 // holding weak references when incremental marking is used, because it also 6712 // holding weak references when incremental marking is used, because it also
6727 // iterates over objects that are otherwise unreachable. 6713 // iterates over objects that are otherwise unreachable.
6728 // In general we only want to call these functions in release mode when 6714 // In general we only want to call these functions in release mode when
6729 // heap verification is turned on. 6715 // heap verification is turned on.
6730 void ZapPrototypeTransitions(); 6716 void ZapPrototypeTransitions();
6731 void ZapTransitions(); 6717 void ZapTransitions();
6732 6718
6733 void DeprecateTransitionTree(); 6719 void DeprecateTransitionTree();
6734 void DeprecateTarget(Name* key, DescriptorArray* new_descriptors); 6720 void DeprecateTarget(Name* key, DescriptorArray* new_descriptors);
6735 6721
6736 Map* FindUpdatedMap(int verbatim, int length, DescriptorArray* descriptors);
6737 Map* FindLastMatchMap(int verbatim, int length, DescriptorArray* descriptors); 6722 Map* FindLastMatchMap(int verbatim, int length, DescriptorArray* descriptors);
6738 6723
6739 void UpdateDescriptor(int descriptor_number, Descriptor* desc); 6724 void UpdateDescriptor(int descriptor_number, Descriptor* desc);
6740 6725
6741 void PrintGeneralization(FILE* file, 6726 void PrintGeneralization(FILE* file,
6742 const char* reason, 6727 const char* reason,
6743 int modify_index, 6728 int modify_index,
6744 int split, 6729 int split,
6745 int descriptors, 6730 int descriptors,
6746 bool constant_to_field, 6731 bool constant_to_field,
(...skipping 4501 matching lines...) Expand 10 before | Expand all | Expand 10 after
11248 } else { 11233 } else {
11249 value &= ~(1 << bit_position); 11234 value &= ~(1 << bit_position);
11250 } 11235 }
11251 return value; 11236 return value;
11252 } 11237 }
11253 }; 11238 };
11254 11239
11255 } } // namespace v8::internal 11240 } } // namespace v8::internal
11256 11241
11257 #endif // V8_OBJECTS_H_ 11242 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698