Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/renderer/net/net_error_page_controller.cc

Issue 259993003: Make sure gin Handles exist before using them (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/dom_automation_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/net/net_error_page_controller.cc
diff --git a/chrome/renderer/net/net_error_page_controller.cc b/chrome/renderer/net/net_error_page_controller.cc
index 66ca54f511d5674ec218549b510a1ea47bb21a0b..81756d665f0e000090d453a8555f66cf0e2906d9 100644
--- a/chrome/renderer/net/net_error_page_controller.cc
+++ b/chrome/renderer/net/net_error_page_controller.cc
@@ -28,6 +28,9 @@ void NetErrorPageController::Install(content::RenderFrame* render_frame) {
gin::Handle<NetErrorPageController> controller = gin::CreateHandle(
isolate, new NetErrorPageController(render_frame));
+ if (controller.IsEmpty())
+ return;
+
v8::Handle<v8::Object> global = context->Global();
global->Set(gin::StringToV8(isolate, "errorPageController"),
controller.ToV8());
« no previous file with comments | « no previous file | content/renderer/dom_automation_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698