Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 25999004: Telemetry: Check in PrintPerfResult that the flattened list is also non-zero. (Closed)

Created:
7 years, 2 months ago by rmcilroy
Modified:
7 years, 2 months ago
Reviewers:
bulach, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Telemetry: Check in PrintPerfResult that the flattened list is also non-zero. BUG=304335 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227271

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M build/util/lib/common/perf_tests_results_helper.py View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/buildbot_page_measurement_results.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/perf_tests_helper.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rmcilroy
I've been seeing errors like the following in the smoothness_measure benchmark: buildbot_page_measurement_results.py, line 95, in ...
7 years, 2 months ago (2013-10-04 16:23:10 UTC) #1
tonyg
lgtm Could you also please mention the newly filed http://crbug.com/304335 in the BUG= field of ...
7 years, 2 months ago (2013-10-05 00:34:51 UTC) #2
rmcilroy
> Could you also please mention the newly filed http://crbug.com/304335 in the > BUG= field ...
7 years, 2 months ago (2013-10-07 07:27:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/25999004/14001
7 years, 2 months ago (2013-10-07 07:28:08 UTC) #4
bulach
late lgtm, sorry for the delay..
7 years, 2 months ago (2013-10-07 07:39:04 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-07 08:19:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/25999004/14001
7 years, 2 months ago (2013-10-07 08:33:36 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-07 08:44:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/25999004/14001
7 years, 2 months ago (2013-10-07 11:11:50 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-07 11:47:02 UTC) #10
Message was sent while issue was closed.
Change committed as 227271

Powered by Google App Engine
This is Rietveld 408576698