Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: trunk/src/base/security_unittest.cc

Issue 25999003: Revert 226978 "Revert 226920 "Roll Clang 188423:191856."" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/base/debug/stack_trace_android.cc ('k') | trunk/src/build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/base/security_unittest.cc
===================================================================
--- trunk/src/base/security_unittest.cc (revision 226993)
+++ trunk/src/base/security_unittest.cc (working copy)
@@ -75,14 +75,11 @@
}
bool CallocDiesOnOOM() {
+// The sanitizers' calloc dies on OOM instead of returning NULL.
// The wrapper function in base/process_util_linux.cc that is used when we
// compile without TCMalloc will just die on OOM instead of returning NULL.
-// This function is explicitly disabled if we compile with AddressSanitizer,
-// MemorySanitizer or ThreadSanitizer.
-#if defined(OS_LINUX) && defined(NO_TCMALLOC) && \
- (!defined(ADDRESS_SANITIZER) && \
- !defined(MEMORY_SANITIZER) && \
- !defined(THREAD_SANITIZER))
+#if defined(ADDRESS_SANITIZER) || defined(MEMORY_SANITIZER) || \
+ defined(THREAD_SANITIZER) || (defined(OS_LINUX) && defined(NO_TCMALLOC))
return true;
#else
return false;
« no previous file with comments | « trunk/src/base/debug/stack_trace_android.cc ('k') | trunk/src/build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698