Trigger the Snippets Scheduler when Resuming Activities

chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index e18d378c7174abf09a22c6cd5e6a9148d610232f..a71206ac15a456adc067e5b8dd7cd7b3be21c542 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -80,6 +80,8 @@ import org.chromium.chrome.browser.metrics.UmaUtils;
 import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
 import org.chromium.chrome.browser.ntp.NativePageAssassin;
 import org.chromium.chrome.browser.ntp.NewTabPageUma;
+import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;
+import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
 import org.chromium.chrome.browser.omaha.OmahaClient;
 import org.chromium.chrome.browser.omnibox.AutocompleteController;
 import org.chromium.chrome.browser.partnercustomizations.HomepageManager;
@@ -87,6 +89,7 @@ import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomiza
 import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
 import org.chromium.chrome.browser.preferences.PrefServiceBridge;
 import org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoScreen;
+import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.chrome.browser.signin.SigninPromoUtil;
 import org.chromium.chrome.browser.snackbar.undo.UndoBarController;
 import org.chromium.chrome.browser.tab.BrowserControlsVisibilityDelegate;
@@ -467,6 +470,11 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
         // If we don't have a current tab, show the overview mode.
         if (getActivityTab() == null) mLayoutManager.showOverview(false);
 
+        if (SnippetsConfig.isEnabled()) {
+            SnippetsBridge mSnippetsBridge = new SnippetsBridge(Profile.getLastUsedProfile());

[dgn, 2016/12/22 15:59:57]

nit: no m prefix for local variables

[fhorschig, 2017/01/03 15:04:25]

I now use a member to store the listener.

+            mSnippetsBridge.onBrowserStarted();

[Michael van Ouwerkerk, 2016/12/23 11:04:42]

This name seems wrong, as this is still not guaranteed to be a browser start.
Like I said, the process could already be running for a service like for push
notifications. Or, this method could run as a member of ChromeTabbedActivity2,
for split windows. So this can run any number of times. I'd suggest renaming to
something like "onActivityStarted" with explicit documentation in that method
that it can be called more than once.

[fhorschig, 2017/01/03 15:04:26]

We figured, that we don't actually want a browser start, so this is gone.
Now, the Activity#Resume event is used and everything is named accordingly.

+        }
+
         resetSavedInstanceState();
     }