Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc

Issue 2599743002: Trigger the Snippets Scheduler when Resuming Activities (Closed)
Patch Set: Remove unnecessary "= false". Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc
diff --git a/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc b/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc
index 315126ec56fbb95ff6f77a819902d5eaa4d0fe27..beb7998151758a7bece168cde70b40d00434bc1a 100644
--- a/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc
+++ b/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc
@@ -180,7 +180,15 @@ void SchedulingRemoteSuggestionsProvider::OnPersistentSchedulerWakeUp() {
RefetchInTheBackground(/*callback=*/nullptr);
}
-void SchedulingRemoteSuggestionsProvider::OnBrowserStartup() {
+void SchedulingRemoteSuggestionsProvider::OnBrowserForegrounded() {
+ // TODO(fhorschig|jkrcal): Consider that this is called whenever we open or
Bernhard Bauer 2017/01/05 16:32:54 This syntax doesn't lend itself very well to grepp
fhorschig 2017/01/05 17:11:13 Changed. Thank you for explaining, I didn't know t
+ // return to an Activity. Therefore, keep work light for fast start up calls.
+ // TODO(jkrcal): Implement.
+}
+
+void SchedulingRemoteSuggestionsProvider::OnBrowserColdStart() {
+ // TODO(fhorschig|jkrcal): Consider that work here must be kept light for fast
+ // cold start ups.
// TODO(jkrcal): Implement.
}

Powered by Google App Engine
This is Rietveld 408576698