Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 2599743002: Trigger the Snippets Scheduler when Resuming Activities (Closed)
Patch Set: Remove unnecessary "= false". Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
index ee8c1fe8c1fce738ea0a2b9204a1aa2b6855c84c..e9dbcfe258a6f10ec5550a5c2ad8b17a22ebac24 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
@@ -410,6 +410,30 @@ void NTPSnippetsBridge::OnNTPInitialized(
scheduler->OnNTPOpened();
}
+void NTPSnippetsBridge::OnColdStart(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj) {
+ ntp_snippets::RemoteSuggestionsScheduler* scheduler =
+ GetRemoteSuggestionsScheduler();
+ // TODO(fhorschig): Remove guard when https://crbug.com/678556 is resolved.
+ if (!scheduler) {
+ return;
+ }
+ scheduler->OnBrowserColdStart();
+}
+
+void NTPSnippetsBridge::OnActivityWarmResumed(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj) {
+ ntp_snippets::RemoteSuggestionsScheduler* scheduler =
+ GetRemoteSuggestionsScheduler();
+ // TODO(fhorschig): Remove guard when https://crbug.com/678556 is resolved.
+ if (!scheduler) {
+ return;
+ }
+ scheduler->OnBrowserForegrounded();
+}
+
NTPSnippetsBridge::~NTPSnippetsBridge() {}
void NTPSnippetsBridge::OnNewSuggestions(Category category) {

Powered by Google App Engine
This is Rietveld 408576698