Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2599743002: Trigger the Snippets Scheduler when Resuming Activities (Closed)
Patch Set: Remove unnecessary "= false". Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index 4625b133e6d759f246aafcec3dd53b68e7adb4b4..3a98264f4f6ea7a61527048bb9bef5456f59bd7f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -179,6 +179,16 @@ public class SnippetsBridge implements SuggestionsSource {
nativeOnNTPInitialized(mNativeSnippetsBridge);
}
+ public static void notifySchedulerAboutWarmResume() {
+ SnippetsBridge snippetsBridge = new SnippetsBridge(Profile.getLastUsedProfile());
+ snippetsBridge.onActivityWarmResumed();
+ }
+
+ public static void notifySchedulerAboutColdStart() {
+ SnippetsBridge snippetsBridge = new SnippetsBridge(Profile.getLastUsedProfile());
+ snippetsBridge.onColdStart();
+ }
+
public static void onSuggestionTargetVisited(int category, long visitTimeMs) {
nativeOnSuggestionTargetVisited(category, visitTimeMs);
}
@@ -208,6 +218,16 @@ public class SnippetsBridge implements SuggestionsSource {
nativeFetch(mNativeSnippetsBridge, category, displayedSuggestionIds);
}
+ private void onActivityWarmResumed() {
+ assert mNativeSnippetsBridge != 0;
+ nativeOnActivityWarmResumed(mNativeSnippetsBridge);
+ }
+
+ private void onColdStart() {
+ assert mNativeSnippetsBridge != 0;
+ nativeOnColdStart(mNativeSnippetsBridge);
+ }
+
@CalledByNative
private static List<SnippetArticle> createSuggestionList() {
return new ArrayList<>();
@@ -312,6 +332,8 @@ public class SnippetsBridge implements SuggestionsSource {
long nativeNTPSnippetsBridge, int category, int position);
private native void nativeOnMoreButtonClicked(
long nativeNTPSnippetsBridge, int category, int position);
+ private native void nativeOnActivityWarmResumed(long nativeNTPSnippetsBridge);
+ private native void nativeOnColdStart(long nativeNTPSnippetsBridge);
private static native void nativeOnSuggestionTargetVisited(int category, long visitTimeMs);
private static native void nativeOnNTPInitialized(long nativeNTPSnippetsBridge);
private native void nativeSetObserver(long nativeNTPSnippetsBridge, SnippetsBridge bridge);

Powered by Google App Engine
This is Rietveld 408576698