Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc

Issue 2599743002: Trigger the Snippets Scheduler when Resuming Activities (Closed)
Patch Set: Used ActivityStateListener and renamed/dropped event functions. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc
diff --git a/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc b/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc
index 7387410d8cc7b624f27103882229b4c152fd2094..400396bb6736c013e8c03418a10d490ad422b92c 100644
--- a/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc
+++ b/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc
@@ -138,11 +138,15 @@ void SchedulingRemoteSuggestionsProvider::OnPersistentSchedulerWakeUp() {
base::Unretained(this))));
}
-void SchedulingRemoteSuggestionsProvider::OnBrowserStartup() {
+void SchedulingRemoteSuggestionsProvider::OnBrowserResumed() {
+ // TODO(fhorschig|jkrcal): Consider that this is called whenever we open or
+ // return to an Activity. Therefore, keep work light for fast start up calls.
// TODO(jkrcal): Implement.
}
void SchedulingRemoteSuggestionsProvider::OnNTPOpened() {
+ // TODO(fhorschig|jkrcal): Consider that this may be called on cold starts,
+ // so keep the work light for this case.
// TODO(jkrcal): Implement.
}

Powered by Google App Engine
This is Rietveld 408576698