Trigger the Snippets Scheduler when Resuming Activities

chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.ActivityManager;
@@ skipping 62 matching lines @@
 import org.chromium.chrome.browser.incognito.IncognitoNotificationManager;
 import org.chromium.chrome.browser.infobar.DataReductionPromoInfoBar;
 import org.chromium.chrome.browser.locale.LocaleManager;
 import org.chromium.chrome.browser.metrics.ActivityStopMetrics;
 import org.chromium.chrome.browser.metrics.LaunchMetrics;
 import org.chromium.chrome.browser.metrics.StartupMetrics;
 import org.chromium.chrome.browser.metrics.UmaUtils;
 import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
 import org.chromium.chrome.browser.ntp.NativePageAssassin;
 import org.chromium.chrome.browser.ntp.NewTabPageUma;
+import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;
+import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
 import org.chromium.chrome.browser.omaha.OmahaClient;
 import org.chromium.chrome.browser.omnibox.AutocompleteController;
 import org.chromium.chrome.browser.partnercustomizations.HomepageManager;
 import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomizations;
 import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
 import org.chromium.chrome.browser.preferences.PrefServiceBridge;
 import org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoScreen;
 import org.chromium.chrome.browser.signin.SigninPromoUtil;
 import org.chromium.chrome.browser.snackbar.undo.UndoBarController;
 import org.chromium.chrome.browser.tab.BrowserControlsVisibilityDelegate;
@@ skipping 129 matching lines @@
     private boolean mCreatedTabOnStartup;
 
     // Whether or not chrome was launched with an intent to open a tab.
     private boolean mIntentWithEffect;
 
     // Time at which an intent was received and handled.
     private long mIntentHandlingTimeMs;
 
     private VrShellDelegate mVrShellDelegate;
 
+    private ApplicationStatus.ActivityStateListener mSnippetsSchedulerListener;
+
     private class TabbedAssistStatusHandler extends AssistStatusHandler {
         public TabbedAssistStatusHandler(Activity activity) {
             super(activity);
         }
 
         @Override
         public boolean isAssistSupported() {
             // If we are in the tab switcher and any incognito tabs are present, disable assist.
             if (isInOverviewMode() && mTabModelSelectorImpl != null
                     && mTabModelSelectorImpl.getModel(true).getCount() > 0) {
@@ skipping 155 matching lines @@
 
             // Check for incognito tabs to handle the case where Chrome was swiped away in the
             // background.
             int incognitoCount = TabWindowManager.getInstance().getIncognitoTabCount();
             if (incognitoCount == 0) IncognitoNotificationManager.dismissIncognitoNotification();
 
             // LocaleManager can only function after the native library is loaded.
             mLocaleManager = LocaleManager.getInstance();
             mLocaleManager.showSearchEnginePromoIfNeeded(this);
 
+            if (SnippetsConfig.isEnabled()) {
+                // The SnippetsBridge propagates the state changes so the scheduler can post
+                // deferred tasks to refresh outdated snippets.
+                mSnippetsSchedulerListener = SnippetsBridge.makeActivityStateListener();
+                ApplicationStatus.registerStateListenerForActivity(
+                        mSnippetsSchedulerListener, this);
+            }
+
             super.finishNativeInitialization();
         } finally {
             TraceEvent.end("ChromeTabbedActivity.finishNativeInitialization");
         }
     }
 
     @Override
     public void onResumeWithNative() {
         super.onResumeWithNative();
 
         CookiesFetcher.restoreCookies(this);
         StartupMetrics.getInstance().recordHistogram(false);
 
         if (FeatureUtilities.isTabModelMergingEnabled()) {
             boolean inMultiWindowMode = MultiWindowUtils.getInstance().isInMultiWindowMode(this);
             // Merge tabs if the activity is not in multi-window mode and mMergeTabsOnResume is true
             // or unset because the activity is just starting or was destroyed.
             if (!inMultiWindowMode && (mMergeTabsOnResume == null || mMergeTabsOnResume)) {
                 maybeMergeTabs();
             }
             mMergeTabsOnResume = false;
         }
         mVrShellDelegate.maybeResumeVR();
 
         mLocaleManager.setSnackbarManager(getSnackbarManager());
         mLocaleManager.startObservingPhoneChanges();
+
+        // Without any interaction, this start was cold and the listener will ignore it.

[Michael van Ouwerkerk, 2017/01/04 14:32:17]

Without user interaction, it is the start of the activity. Not guaranteed to be
cold, as the native library might have been loaded already for a service or
another activity.

[fhorschig, 2017/01/04 15:04:44]

Good lead, added a check and a warm alternative call for this case.

+        if (SnippetsConfig.isEnabled() && getLastUserInteractionTime() == 0) {
+            SnippetsBridge.notifySchedulerAboutColdStart();
+        }
     }
 
     @Override
     public void onPauseWithNative() {
         mTabModelSelectorImpl.commitAllTabClosures();
         CookiesFetcher.persistCookies(this);
         mVrShellDelegate.maybePauseVR();
 
         mLocaleManager.setSnackbarManager(null);
         mLocaleManager.stopObservingPhoneChanges();
@@ skipping 994 matching lines @@
 
         if (mUndoBarPopupController != null) {
             mUndoBarPopupController.destroy();
             mUndoBarPopupController = null;
         }
 
         if (mVrShellDelegate != null) {
             mVrShellDelegate.destroyVrShell();
         }
 
+        if (mSnippetsSchedulerListener != null) {
+            ApplicationStatus.unregisterActivityStateListener(mSnippetsSchedulerListener);
+            mSnippetsSchedulerListener = null;
+        }
+
         super.onDestroyInternal();
     }
 
     @Override
     public void onTrimMemory(int level) {
         super.onTrimMemory(level);
         // The conditions are expressed using ranges to capture intermediate levels possibly added
         // to the API in the future.
         if ((level >= TRIM_MEMORY_RUNNING_LOW && level < TRIM_MEMORY_UI_HIDDEN)
                 || level >= TRIM_MEMORY_MODERATE) {
@@ skipping 246 matching lines @@
 
         ActivityManager manager = (ActivityManager) getSystemService(Context.ACTIVITY_SERVICE);
         for (AppTask task : manager.getAppTasks()) {
             RecentTaskInfo info = DocumentUtils.getTaskInfoFromTask(task);
             if (info == null) continue;
             if (info.id == sMergedInstanceTaskId) return true;
         }
         return false;
     }
 }