Issue 2599723002: Revert "Make File.create() fail when a directory exists at the same path"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2599723002: Revert "Make File.create() fail when a directory exists at the same path" (Closed)

Created:
4 years ago by kasperl

Modified:
4 years ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Make File.create() fail when a directory exists at the same path" The added test case fails in non-English locales. This reverts commit f2604a3647fce4f0a6feac34ee152a3dc103acdd. TBR'ed. R=zra@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/101552b0330a950b81b7a014b62caf1838054375

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -126 lines)			Patch
M	runtime/bin/file_android.cc	View	3 chunks	+3 lines, -19 lines	0 comments	Download
M	runtime/bin/file_fuchsia.cc	View	2 chunks	+5 lines, -22 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View	3 chunks	+2 lines, -19 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View	2 chunks	+2 lines, -18 lines	0 comments	Download
D	tests/standalone/io/file_create_test.dart	View	1 chunk	+0 lines, -48 lines	0 comments	Download

Total messages: 3 (1 generated)

kasperl

4 years ago (2016-12-22 08:56:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
101552b0330a950b81b7a014b62caf1838054375 (presubmit successful).