Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 25997003: Add newline to end of file. (Closed)

Created:
7 years, 2 months ago by Justin Cohen (wrong one)
Modified:
7 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add newline to end of file. Fix [-Werror,-Wnewline-eof] error in base/test/unit_test_launcher_ios.cc BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227517

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/test/launcher/unit_test_launcher_ios.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
justincohen
PTAL
7 years, 2 months ago (2013-10-04 17:10:30 UTC) #1
Paweł Hajdan Jr.
LGTM
7 years, 2 months ago (2013-10-04 18:03:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/25997003/1
7 years, 2 months ago (2013-10-04 18:04:25 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=86084
7 years, 2 months ago (2013-10-04 23:03:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/25997003/1
7 years, 2 months ago (2013-10-04 23:34:20 UTC) #5
commit-bot: I haz the power
Failed to apply patch for base/test/unit_test_launcher_ios.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 2 months ago (2013-10-04 23:34:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/25997003/29001
7 years, 2 months ago (2013-10-05 12:43:26 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-05 13:29:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/25997003/54001
7 years, 2 months ago (2013-10-06 13:24:20 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-06 14:07:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/25997003/54001
7 years, 2 months ago (2013-10-07 14:53:08 UTC) #11
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-07 14:55:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/25997003/81001
7 years, 2 months ago (2013-10-07 15:14:12 UTC) #13
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-07 15:55:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/25997003/81001
7 years, 2 months ago (2013-10-08 12:50:44 UTC) #15
commit-bot: I haz the power
7 years, 2 months ago (2013-10-08 15:01:08 UTC) #16
Message was sent while issue was closed.
Change committed as 227517

Powered by Google App Engine
This is Rietveld 408576698