Issue 2599673004: Revert "GN: Make GN the default"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2599673004: Revert "GN: Make GN the default" (Closed)

Created:
4 years ago by zra

Modified:
4 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "GN: Make GN the default" This reverts commit ca864e93a1059c4533049832807034a9186dfe54. Reverting for unforseen failures in dart2js testing. Committed: https://github.com/dart-lang/sdk/commit/02447e5b8058d45a0af559ad90d1ae5562a10675

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -26 lines)			Patch
M	tools/bots/gn_build.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/build.py	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	tools/generate_buildfiles.py	View	4 chunks	+12 lines, -17 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

Committed patchset #1 (id:1) manually as 02447e5b8058d45a0af559ad90d1ae5562a10675.

4 years ago (2016-12-22 21:43:08 UTC) #4

Message was sent while issue was closed.

LGTM.