Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 25994002: Explicitly include defaults.cc in the shared_library gyp target. (Closed)

Created:
7 years, 2 months ago by rmcilroy
Modified:
7 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Explicitly include defaults.cc in the shared_library gyp target. Explicitly include defaults.cc in the shared_library gyp target, otherwise the whole compilation unit is stripped by the Windows linker, since none of it's symbols are referenced by any other compilation unit in V8. BUG=None R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/defaults.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
As discussed re: https://codereview.chromium.org/24550008/, this fixes the link error on the Window's component build. Another ...
7 years, 2 months ago (2013-10-04 10:34:29 UTC) #1
Jakob Kummerow
LGTM. Maybe it would be cleaner after all to merge the defaults stuff into v8.h/api.cc. ...
7 years, 2 months ago (2013-10-04 11:13:22 UTC) #2
Jakob Kummerow
7 years, 2 months ago (2013-10-04 11:57:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17107.

Powered by Google App Engine
This is Rietveld 408576698