Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2599313002: Create headerHeightForTab in TabHeadersDelegate. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_headers_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 96a7e1384d5a4ca4e19d7957b06151b6aeffe29a..ac3fc801afe84e5b93cab59ad4eb6d5e274d8f55 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -77,6 +77,7 @@
#import "ios/chrome/browser/storekit_launcher.h"
#import "ios/chrome/browser/tabs/tab.h"
#import "ios/chrome/browser/tabs/tab_dialog_delegate.h"
+#import "ios/chrome/browser/tabs/tab_headers_delegate.h"
#import "ios/chrome/browser/tabs/tab_model.h"
#import "ios/chrome/browser/tabs/tab_model_observer.h"
#import "ios/chrome/browser/tabs/tab_snapshotting_delegate.h"
@@ -310,6 +311,7 @@ NSString* const kReadingListSnackbarCategory = @"ReadingListSnackbarCategory";
SnapshotOverlayProvider,
StoreKitLauncher,
TabDialogDelegate,
+ TabHeadersDelegate,
TabModelObserver,
TabSnapshottingDelegate,
UIGestureRecognizerDelegate,
@@ -737,8 +739,6 @@ NSString* const kReadingListSnackbarCategory = @"ReadingListSnackbarCategory";
- (UIView*)footerView;
// Returns the height of the header view for the tab model's current tab.
- (CGFloat)headerHeight;
-// Returns the height of the header view for |tab|.
-- (CGFloat)headerHeightForTab:(Tab*)tab;
// Sets the frame for the headers.
- (void)setFramesForHeaders:(const std::vector<HeaderDefinition>)headers
atOffset:(CGFloat)headerOffset;
@@ -2110,6 +2110,7 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
if (!IsIPadIdiom()) {
tab.overscrollActionsControllerDelegate = self;
}
+ tab.tabHeadersDelegate = self;
tab.tabSnapshottingDelegate = self;
// Install the proper CRWWebController delegates.
tab.webController.nativeProvider = self;
« no previous file with comments | « ios/chrome/browser/tabs/tab_headers_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698