Create headerHeightForTab in TabHeadersDelegate.

ios/chrome/browser/ui/browser_view_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 
 #import <AssetsLibrary/AssetsLibrary.h>
 #import <MobileCoreServices/MobileCoreServices.h>
 #import <PassKit/PassKit.h>
 #import <Photos/Photos.h>
@@ skipping 59 matching lines @@
 #include "ios/chrome/browser/search_engines/template_url_service_factory.h"
 #include "ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.h"
 #include "ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.h"
 #include "ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios_factory.h"
 #import "ios/chrome/browser/snapshots/snapshot_cache.h"
 #import "ios/chrome/browser/snapshots/snapshot_overlay.h"
 #import "ios/chrome/browser/snapshots/snapshot_overlay_provider.h"
 #import "ios/chrome/browser/storekit_launcher.h"
 #import "ios/chrome/browser/tabs/tab.h"
 #import "ios/chrome/browser/tabs/tab_dialog_delegate.h"
+#import "ios/chrome/browser/tabs/tab_headers_delegate.h"
 #import "ios/chrome/browser/tabs/tab_model.h"
 #import "ios/chrome/browser/tabs/tab_model_observer.h"
 #import "ios/chrome/browser/tabs/tab_snapshotting_delegate.h"
 #import "ios/chrome/browser/ui/activity_services/share_protocol.h"
 #import "ios/chrome/browser/ui/activity_services/share_to_data.h"
 #import "ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h"
 #import "ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.h"
 #import "ios/chrome/browser/ui/background_generator.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.h"
 #import "ios/chrome/browser/ui/browser_container_view.h"
@@ skipping 213 matching lines @@
                                     MFMailComposeViewControllerDelegate,
                                     NewTabPageControllerObserver,
                                     OverscrollActionsControllerDelegate,
                                     PassKitDialogProvider,
                                     PreloadControllerDelegate,
                                     ShareToDelegate,
                                     SKStoreProductViewControllerDelegate,
                                     SnapshotOverlayProvider,
                                     StoreKitLauncher,
                                     TabDialogDelegate,
+                                    TabHeadersDelegate,
                                     TabModelObserver,
                                     TabSnapshottingDelegate,
                                     UIGestureRecognizerDelegate,
                                     UpgradeCenterClientProtocol,
                                     VoiceSearchBarDelegate,
                                     VoiceSearchBarOwner> {
   // The dependency factory passed on initialization.  Used to vend objects used
   // by the BVC.
   base::scoped_nsobject<BrowserViewControllerDependencyFactory>
       _dependencyFactory;
@@ skipping 406 matching lines @@
 // animation.
 - (id<LogoAnimationControllerOwner>)currentLogoAnimationControllerOwner;
 // Returns the header views, all the chrome on top of the page, including the
 // ones that cannot be scrolled off screen by full screen.
 - (const std::vector<HeaderDefinition>)headerViews;
 // Returns the footer view if one exists (e.g. the voice search bar).
 - (UIView*)footerView;
 // Returns the height of the header view for the tab model's current tab.
 - (CGFloat)headerHeight;
 // Returns the height of the header view for |tab|.
 - (CGFloat)headerHeightForTab:(Tab*)tab;

[rohitrao (ping after 24h), 2017/01/10 17:15:25]

This can be removed from the forward-declaration list.

[Olivier, 2017/01/10 18:27:09]

Done.

 // Sets the frame for the headers.
 - (void)setFramesForHeaders:(const std::vector<HeaderDefinition>)headers
                    atOffset:(CGFloat)headerOffset;
 // Returns the y coordinate for the footer's frame when animating the footer
 // in/out of fullscreen.
 - (CGFloat)footerYForHeaderOffset:(CGFloat)headerOffset;
 // Called when the animation for setting the header view's offset is finished.
 // |completed| should indicate if the animation finished completely or was
 // interrupted. |offset| should indicate the header offset after the animation.
 // |dragged| should indicate if the header moved due to the user dragging.
@@ skipping 1351 matching lines @@
   // TODO(crbug.com/375577): Unregister these delegates correctly on BVC
   // deallocation.
   tab.dialogDelegate = self;
   tab.snapshotOverlayProvider = self;
   tab.storeKitLauncher = self;
   tab.passKitDialogProvider = self;
   tab.fullScreenControllerDelegate = self;
   if (!IsIPadIdiom()) {
     tab.overscrollActionsControllerDelegate = self;
   }
+  tab.tabHeadersDelegate = self;
   tab.tabSnapshottingDelegate = self;
   // Install the proper CRWWebController delegates.
   tab.webController.nativeProvider = self;
   tab.webController.swipeRecognizerProvider = self.sideSwipeController;
   // Delegate will remove itself on destruction.
   tab.webState->SetDelegate(_webStateDelegate.get());
 }
 
 // Called when a tab is selected in the model. Make any required view changes.
 // The notification will not be sent when the tab is already the selected tab.
@@ skipping 456 matching lines @@
       results.push_back(header);
     }
   }
   return results;
 }
 
 - (UIView*)footerView {
   return _voiceSearchBar;
 }
 
 - (CGFloat)headerHeight {

[rohitrao (ping after 24h), 2017/01/10 17:15:25]

Does anyone still call this method?  Should we rename it to currentHeaderHeight?

[Olivier, 2017/01/10 18:27:09]

Yes, it is still in SideSwipeController and FullScreenController. We can rename
it if needed.

   return [self headerHeightForTab:[_model currentTab]];
 }
 
 - (CGFloat)headerHeightForTab:(Tab*)tab {
   id nativeController = [self nativeControllerForTab:tab];
   if ([nativeController conformsToProtocol:@protocol(ToolbarOwner)] &&
       [nativeController respondsToSelector:@selector(toolbarHeight)] &&
       [nativeController toolbarHeight] > 0.0 && !IsIPadIdiom()) {
     // On iPhone, don't add any header height for ToolbarOwner native
     // controllers when they're displaying their own toolbar.
@@ skipping 2498 matching lines @@
 
 - (UIView*)voiceSearchButton {
   return _voiceSearchButton;
 }
 
 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
   return [self currentLogoAnimationControllerOwner];
 }
 
 @end