src/heap/mark-compact.cc - Issue 2599283002: Reland "[heap] Ensure progress when incrementally marking wrappers"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/mark-compact.cc

Issue 2599283002: Reland "[heap] Ensure progress when incrementally marking wrappers" (Closed)

Patch Set: Fix: Make toggle a IM global to avoid only advancing wrappers Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/mark-compact.cc

diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc

index 52e1706b82ac3637625f155c558f640c08362c23..2b532c603b68b063b5388995e81b875a3ecf3d56 100644

--- a/src/heap/mark-compact.cc

+++ b/src/heap/mark-compact.cc

@@ -2157,7 +2157,8 @@ void MarkCompactCollector::ProcessEphemeralMarking(

work_to_do = !marking_deque()->IsEmpty();

ProcessMarkingDeque<MarkCompactMode::FULL>();

}

- CHECK(heap_->MarkingDequesAreEmpty());

+ CHECK(marking_deque()->IsEmpty());

+ CHECK_EQ(0, heap()->local_embedder_heap_tracer()->NumberOfWrappersToTrace());

}

void MarkCompactCollector::ProcessTopOptimizedFrame(ObjectVisitor* visitor) {

« no previous file with comments | « src/heap/incremental-marking.cc ('k') | no next file » | no next file with comments »