third_party/protobuf/patches/0012-fixes-for-js-embed-cc.patch - Issue 2599263002: third_party/protobuf: Update to HEAD (f52e188fe4)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/protobuf/patches/0012-fixes-for-js-embed-cc.patch

Issue 2599263002: third_party/protobuf: Update to HEAD (f52e188fe4) (Closed)

Patch Set: Address comments Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/.gitignore b/.gitignore

	2 index 4f42646..8b42cac 100644

	3 --- a/.gitignore

	4 +++ b/.gitignore

	5 @@ -47,7 +47,6 @@ any_test.pb.*

	6 mapunittest.pb.

	7 unittest.pb.

	8 cpp_test.pb.

	9 -src/google/protobuf/compiler/js/well_known_types_embed.cc

	10 src/google/protobuf/util/*/.pb.cc

	11 src/google/protobuf/util/*/.pb.h

	12

	13 diff --git a/src/google/protobuf/compiler/js/embed.cc b/src/google/protobuf/comp iler/js/embed.cc

	14 index d04fea2..cfa84a9 100644

	15 --- a/src/google/protobuf/compiler/js/embed.cc

	16 +++ b/src/google/protobuf/compiler/js/embed.cc

	17 @@ -98,7 +98,7 @@ static void AddFile(const char* name, std::basic_ostream<char> * out) {

	18

	19 int main(int argc, char *argv[]) {

	20 std::cout << "#include "

	21 - "\"google/protobuf/compiler/js/well_known_types_embed.h\"\n";

	22 + "<google/protobuf/compiler/js/well_known_types_embed.h>\n";

	23 std::cout << "struct FileToc well_known_types_js[] = {\n";

	24

	25 for (int i = 1; i < argc; i++) {

OLD	NEW