Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2599213002: More kernel-ification of type variables passed around constructors. (Closed)

Created:
4 years ago by Emily Fortuna
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More kernel-ification of type variables passed around constructors. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/bf52b33b14b5db4662c56c89c89e6e6963305070

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +15 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Emily Fortuna
Quick follow-up to the last CL. Stephen wanted me to write that logic by looking ...
4 years ago (2016-12-22 23:37:20 UTC) #3
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-12-23 00:05:02 UTC) #4
Emily Fortuna
4 years ago (2016-12-23 00:34:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
bf52b33b14b5db4662c56c89c89e6e6963305070 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698