Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 2599073002: dart2js rti fix: functions are subtypes of Object (Closed)

Created:
4 years ago by Siggi Cherem (dart-lang)
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M sdk/lib/_internal/js_runtime/lib/js_rti.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/function_subtype0_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/language/function_subtype1_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
4 years ago (2016-12-22 16:54:26 UTC) #3
Emily Fortuna
lgtm
4 years ago (2016-12-22 18:15:30 UTC) #4
Siggi Cherem (dart-lang)
Committed patchset #1 (id:20001) manually as 7c3c297a8ad907f12bf12b96a21777421067fd18 (presubmit successful).
4 years ago (2016-12-22 19:16:22 UTC) #6
Johnni Winther
3 years, 11 months ago (2017-01-02 08:56:14 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698