Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

Issue 2599063002: [minidump uploader] Retries: only initiate uploads when on WiFi/Ethernet (Closed)
Patch Set: Fix Maria's comments (early out from retries if there is no connection). Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
index 87103c9c8f13f1a52c118ceea0723e4c5379de13..05f52e9db602b5d862e102aa1691978f7c900c0f 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
@@ -22,6 +22,7 @@ import org.chromium.base.test.util.Feature;
import org.chromium.components.minidump_uploader.CrashFileManager;
import org.chromium.components.minidump_uploader.CrashTestCase;
import org.chromium.components.minidump_uploader.MinidumpUploadCallable;
+import org.chromium.components.minidump_uploader.util.CrashReportingPermissionManager;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
import org.chromium.net.NetworkChangeNotifier;
@@ -79,6 +80,8 @@ public class MinidumpUploadServiceTest extends CrashTestCase {
}
private static class TestMinidumpUploadService extends MinidumpUploadService {
+ private final NetworkChangingPermissionManager mPermissionManager =
+ new NetworkChangingPermissionManager();
private TestMinidumpUploadService() {}
private TestMinidumpUploadService(Context context) {
attachBaseContext(context);
@@ -87,6 +90,25 @@ public class MinidumpUploadServiceTest extends CrashTestCase {
private void attachBaseContextLate(Context base) {
super.attachBaseContext(base);
}
+
+ private static class NetworkChangingPermissionManager
+ extends MockCrashReportingPermissionManager {
+ public boolean isNetworkAvailableForCrashUploads() {
+ return mIsNetworkAvailable;
+ }
+
+ public void setIsNetworkAvailableForCrashUploads(boolean networkAvailable) {
+ mIsNetworkAvailable = networkAvailable;
+ }
+ }
+
+ CrashReportingPermissionManager getCrashReportingPermissionManager() {
+ return mPermissionManager;
+ }
+
+ public void setIsNetworkAvailableForCrashUploads(boolean networkAvailable) {
+ mPermissionManager.setIsNetworkAvailableForCrashUploads(networkAvailable);
+ }
}
@SmallTest
@@ -270,7 +292,9 @@ public class MinidumpUploadServiceTest extends CrashTestCase {
NetworkChangeNotifier.setAutoDetectConnectivityState(false);
// Quickly force the state to be connected and back to disconnected.
// An event should be triggered for retry logics.
+ setIsNetworkAvailableForCrashUploads(false);
NetworkChangeNotifier.forceConnectivityState(false);
+ setIsNetworkAvailableForCrashUploads(true);
NetworkChangeNotifier.forceConnectivityState(true);
}
});
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698