Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 25990002: Load/Store cannot handle double representation. (Closed)

Created:
7 years, 2 months ago by Benedikt Meurer
Modified:
7 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Load/Store cannot handle double representation. Assert that the representation for Load/Store in the X64 MacroAssembler is never Double. Also add missing test case for the Load/Store macros. TEST=cctest/test-macro-assembler-x64 R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17135 Committed: https://code.google.com/p/v8/source/detail?r=17151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -0 lines) Patch
M src/x64/macro-assembler-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 2 chunks +113 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Hey Michael, Missing from that previous CL. PTAL -- Benedikt
7 years, 2 months ago (2013-10-04 09:37:39 UTC) #1
mvstanton
lgtm
7 years, 2 months ago (2013-10-10 11:41:08 UTC) #2
Benedikt Meurer
Committed patchset #1 manually as r17135 (presubmit successful).
7 years, 2 months ago (2013-10-10 11:42:13 UTC) #3
Benedikt Meurer
7 years, 2 months ago (2013-10-11 07:12:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r17151 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698