tests/corelib/iterable_generate_test.dart - Issue 2598983002: Introduce DartType super hierarchy based on Entity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/corelib/iterable_generate_test.dart

Issue 2598983002: Introduce DartType super hierarchy based on Entity (Closed)

Patch Set: Cleanup. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/corelib/iterable_generate_test.dart

diff --git a/tests/corelib/iterable_generate_test.dart b/tests/corelib/iterable_generate_test.dart

index 170dba91c62231fb1a853097c0bc509390f464a5..d73a1841f39ef2261ab592222e63e237f3ba96d4 100644

--- a/tests/corelib/iterable_generate_test.dart

+++ b/tests/corelib/iterable_generate_test.dart

@@ -59,7 +59,9 @@ main() {

// Invalid types:

Expect.throws(() => new Iterable<String>.generate(5));

- Expect.throws(() => new Iterable<Null>.generate(5));

+ Expect.throws(() {

+ new Iterable<Null>.generate(5).elementAt(2);

Siggi Cherem (dart-lang) 2016/12/22 15:42:03 not sure I follow: why is this change needed?

Johnni Winther 2016/12/22 15:58:49 From a different CL. Removed.

+ });

Expect.throws(() => new Iterable<bool>.generate(5));

// Regression: https://github.com/dart-lang/sdk/issues/26358