Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 259893002: ServiceWorker: Additional scope-matching test cases (Closed)

Created:
6 years, 8 months ago by jsbell
Modified:
6 years, 7 months ago
Reviewers:
michaeln
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker: Additional scope-matching test cases Tests to ensure that ?-escaping works and \-escaping is not necessary. BUG=360629 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_utils_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
Had this sitting around, seems worth landing. r? cq? anyone?
6 years, 8 months ago (2014-04-25 20:56:28 UTC) #1
michaeln
oh just now noticing this... lgtm
6 years, 7 months ago (2014-04-29 01:11:10 UTC) #2
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 7 months ago (2014-04-29 19:29:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/259893002/1
6 years, 7 months ago (2014-04-29 19:30:05 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 00:59:29 UTC) #5
Message was sent while issue was closed.
Change committed as 267016

Powered by Google App Engine
This is Rietveld 408576698