tools/grit/grit/format/html_inline_unittest.py - Issue 2598863002: Allow and better handle single quotes in GRIT's <include> and <if>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grit/grit/format/html_inline_unittest.py

Issue 2598863002: Allow and better handle single quotes in GRIT's <include> and <if> (Closed)

Patch Set: more correcter quotes Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/grit/grit/format/html_inline_unittest.py

diff --git a/tools/grit/grit/format/html_inline_unittest.py b/tools/grit/grit/format/html_inline_unittest.py

index 16674cfe237432ee3b8db55066381fdbe2da174b..c236f4f7483de356f6ff3bbe05baab63ba64d011 100755

--- a/tools/grit/grit/format/html_inline_unittest.py

+++ b/tools/grit/grit/format/html_inline_unittest.py

@@ -34,7 +34,7 @@ class HtmlInlineUnittest(unittest.TestCase):

href="really-long-long-long-long-long-test.css">

</head>

<body>

- <include src="test.html">

+ <include src='test.html'>

<include

src="really-long-long-long-long-long-test-file-omg-so-long.html">

<iron-icon src="[[icon]]"></iron-icon>

@@ -90,6 +90,9 @@ class HtmlInlineUnittest(unittest.TestCase):

bonjour

</if>

+ <if expr='lang == "de"'>

+ hallo

+ </if>

</if>

</html>

''',

@@ -397,6 +400,8 @@ class HtmlInlineUnittest(unittest.TestCase):

</include>

+ <include src='single-double-quotes.html"></include>

Nico 2017/01/04 01:35:33 Does the file single-double-quotes.html exist? (no

Dan Beam 2017/01/04 01:40:59 no, neither of these files exist. if they're acci

+ <include src="double-single-quotes.html'></include>

</html>

''',

'style1.css': '''h1 {}''',

@@ -419,6 +424,8 @@ class HtmlInlineUnittest(unittest.TestCase):

+ <include src='single-double-quotes.html"></include>

+ <include src="double-single-quotes.html'></include>

</html>

'''

« no previous file with comments | « tools/grit/grit/format/html_inline.py ('k') | no next file » | no next file with comments »