[ios] Open links in history status message in new tab and add test

ios/chrome/browser/ui/history/history_ui_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <EarlGrey/EarlGrey.h>
 #import <UIKit/UIKit.h>
 #import <XCTest/XCTest.h>
 
 #include "base/strings/sys_string_conversions.h"
 #include "components/browsing_data/core/pref_names.h"
 #include "components/prefs/pref_service.h"
 #include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
+#include "ios/chrome/browser/chrome_url_constants.h"
+#import "ios/chrome/browser/ui/history/history_entries_status_item.h"
 #import "ios/chrome/browser/ui/history/history_entry_item.h"
 #import "ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.h"
+#import "ios/chrome/browser/ui/settings/settings_collection_view_controller.h"
+#import "ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h"
+#import "ios/chrome/browser/ui/tools_menu/tools_popup_controller.h"
+#import "ios/chrome/browser/ui/util/transparent_link_button.h"
+#include "ios/chrome/common/string_util.h"
 #include "ios/chrome/grit/ios_strings.h"
 #import "ios/chrome/test/app/chrome_test_util.h"
 #import "ios/chrome/test/earl_grey/accessibility_util.h"
 #import "ios/chrome/test/earl_grey/chrome_assertions.h"
 #import "ios/chrome/test/earl_grey/chrome_earl_grey.h"
 #import "ios/chrome/test/earl_grey/chrome_earl_grey_ui.h"
 #import "ios/chrome/test/earl_grey/chrome_matchers.h"
 #import "ios/chrome/test/earl_grey/chrome_test_case.h"
+#import "ios/public/provider/chrome/browser/signin/chrome_identity.h"
+#import "ios/public/provider/chrome/browser/signin/fake_chrome_identity.h"
+#import "ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h"
 #import "ios/testing/wait_util.h"
 #import "ios/web/public/test/http_server.h"
 #import "ios/web/public/test/http_server_util.h"
 #import "net/base/mac/url_conversions.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using chrome_test_util::buttonWithAccessibilityLabelId;
 
 namespace {
 char kURL1[] = "http://firstURL";
@@ skipping 66 matching lines @@
 // Matcher for the clear cache cell on the clear browsing data panel.
 id<GREYMatcher> clearCacheButton() {
   return grey_allOf(grey_accessibilityID(kClearCacheCellId),
                     grey_sufficientlyVisible(), nil);
 }
 // Matcher for the clear browsing data button on the clear browsing data panel.
 id<GREYMatcher> clearBrowsingDataButton() {
   return buttonWithAccessibilityLabelId(IDS_IOS_CLEAR_BUTTON);
 }
 
+void SignIn() {

[baxley, 2016/12/22 17:58:37]

Could you add a comment?

What do you think about a more descriptive name? SignInFakeIdentity? 
Unfortunately I feel like "SignIn" isn't descriptive enough, but I can't think
of something any better... Up to you.

[Jackie Quinn, 2016/12/22 20:09:13]

Works for me. Done.

+  // Set up a fake identity.
+  ChromeIdentity* identity =
+      [FakeChromeIdentity identityWithEmail:@"foo@gmail.com"
+                                     gaiaID:@"fooID"
+                                       name:@"Fake Foo"];
+  ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity(
+      identity);
+
+  const CGFloat scroll_displacement = 50.0;

[baxley, 2016/12/22 17:58:37]

Is reliable on phones and iPads?

Sergio fixed some flake by using "grey_scrollToContentEdge(..." instead. If this
works on multiple form factors (big/small landscape/portrait) then I think it's
fine.

[Jackie Quinn, 2016/12/22 20:09:13]

Oh yeah that seems to be a better solution! Updated.

In this case, the sign in element is at the top of the collection, so it's
probably not a big deal (I had just copied over from the sign in egtests 🙃).

+  [ChromeEarlGreyUI openToolsMenu];
+  [[[EarlGrey
+      selectElementWithMatcher:grey_accessibilityID(kToolsMenuSettingsId)]
+         usingSearchAction:grey_scrollInDirection(kGREYDirectionDown,
+                                                  scroll_displacement)
+      onElementWithMatcher:grey_accessibilityID(kToolsMenuTableViewId)]
+      performAction:grey_tap()];
+
+  [[EarlGrey
+      selectElementWithMatcher:grey_accessibilityID(kSettingsSignInCellId)]
+      performAction:grey_tap()];
+  [[EarlGrey
+      selectElementWithMatcher:chrome_test_util::buttonWithAccessibilityLabel(
+                                   identity.userEmail)]
+      performAction:grey_tap()];
+  [[EarlGrey selectElementWithMatcher:
+                 chrome_test_util::buttonWithAccessibilityLabelId(
+                     IDS_IOS_ACCOUNT_CONSISTENCY_SETUP_SIGNIN_BUTTON)]
+      performAction:grey_tap()];
+  [[EarlGrey selectElementWithMatcher:
+                 chrome_test_util::buttonWithAccessibilityLabelId(
+                     IDS_IOS_ACCOUNT_CONSISTENCY_CONFIRMATION_OK_BUTTON)]
+      performAction:grey_tap()];
+  [[EarlGrey
+      selectElementWithMatcher:chrome_test_util::buttonWithAccessibilityLabelId(
+                                   IDS_IOS_NAVIGATION_BAR_DONE_BUTTON)]
+      performAction:grey_tap()];
+}
 }  // namespace
 
 // History UI tests.
-@interface HistoryUITestCase : ChromeTestCase {
+@interface AAAHistoryUITestCase : ChromeTestCase {

[baxley, 2016/12/22 17:58:37]

What you think your special and can make your test run first? :)

[Jackie Quinn, 2016/12/22 20:09:13]

Isn't history our most important feature? Done.

[baxley, 2016/12/22 22:35:32]

By the way, you should have totally called me out on using "your" instead of
"you're"

[Jackie Quinn, 2016/12/22 22:45:14]

Dang, missed opportunity 🙃

   GURL _URL1;
   GURL _URL2;
   GURL _URL3;
 }
 
 // Loads three test URLs.
 - (void)loadTestURLs;
 // Displays the history UI.
 - (void)openHistoryPanel;
 // Asserts that the history UI displays no history entries.
 - (void)assertNoHistoryShown;
 // Resets which data is selected in the Clear Browsing Data UI.
 - (void)resetBrowsingDataPrefs;
 
 @end
 
-@implementation HistoryUITestCase
+@implementation AAAHistoryUITestCase
 
 // Set up called once for the class.
 + (void)setUp {
   [super setUp];
   std::map<GURL, std::string> responses;
   responses[web::test::HttpServer::MakeUrl(kURL1)] = kResponse1;
   responses[web::test::HttpServer::MakeUrl(kURL2)] = kResponse2;
   responses[web::test::HttpServer::MakeUrl(kURL3)] = kResponse3;
   web::test::SetUpSimpleHttpServer(responses);
 }
@@ skipping 50 matching lines @@
 
   // Tap a history entry and assert that navigation to that entry's URL occurs.
   [[EarlGrey selectElementWithMatcher:historyEntryWithURL(_URL1)]
       performAction:grey_tap()];
   id<GREYMatcher> webViewMatcher =
       chrome_test_util::webViewContainingText(kResponse1);
   [[EarlGrey selectElementWithMatcher:webViewMatcher]
       assertWithMatcher:grey_notNil()];
 }
 
+// Test that history displays a message about entries only if the user is logged
+// in, and that tapping on the link in the message opens a new tab with the sync
+// help page.
+- (void)testHistoryEntriesStatusCell {
+  [self loadTestURLs];
+  [self openHistoryPanel];
+  // Assert that no message is shown when the user is not signed in.
+  GREYElementMatcherBlock* emptyEntriesItemMatcher =
+      [GREYElementMatcherBlock matcherWithMatchesBlock:^BOOL(id element) {
+        HistoryEntriesStatusCell* cell = (HistoryEntriesStatusCell*)element;

[baxley, 2016/12/22 17:58:37]

ObjCCast ?

[Jackie Quinn, 2016/12/22 20:09:13]

Done.

+        return !cell.textLabel.text;
+      }
+          descriptionBlock:^void(id<GREYDescription> description) {
+            [description
+                appendText:@"HistoryEntriesStatusCell does not display text"];
+          }];
+  [[EarlGrey selectElementWithMatcher:grey_kindOfClass(
+                                          [HistoryEntriesStatusCell class])]
+      assertWithMatcher:emptyEntriesItemMatcher];

[baxley, 2016/12/22 17:58:37]

Do we need to know about the class type? we can't verify this by text or
anything else on (or not on) the screen?

[Jackie Quinn, 2016/12/22 20:09:13]

Well, I could wait for the text I look for below to not be on the screen.
Updated. 

+  [[EarlGrey selectElementWithMatcher:navigationDoneButton()]
+      performAction:grey_tap()];
+
+  // Sign in and assert that the page indicates what type of history entries
+  // are shown.
+  SignIn();
+  [self openHistoryPanel];
+  // Assert that message about entries is shown. The "history is showing local
+  // entries" message will be shown because sync is not set up for this test.
+  l10n_util::GetNSString(IDS_IOS_HISTORY_NO_SYNCED_RESULTS);
+  NSRange range;
+  NSString* text = ParseStringWithLink(
+      l10n_util::GetNSString(IDS_IOS_HISTORY_NO_SYNCED_RESULTS), &range);
+  [[EarlGrey selectElementWithMatcher:grey_text(text)]
+      assertWithMatcher:grey_notNil()];
+
+  // Tap on "Learn more" link and assert that new tab with the link is opened.
+  [[EarlGrey
+      selectElementWithMatcher:grey_kindOfClass([TransparentLinkButton class])]

[baxley, 2016/12/22 17:58:37]

Is there anything we can use to match the link, other than the class type?

[Jackie Quinn, 2016/12/22 20:09:13]

I don't think so... I could look for the first UI button without any text? The
problem is it doesn't have any other distinguishing features :-( Let me know
what you think.

+      performAction:grey_tap()];
+  chrome_test_util::AssertMainTabCount(2);
+  id<GREYMatcher> webViewMatcher = chrome_test_util::webViewContainingText(
+      "Sync and view tabs and history across devices");
+  [[EarlGrey selectElementWithMatcher:webViewMatcher]
+      assertWithMatcher:grey_notNil()];

[baxley, 2016/12/22 17:58:37]

Are the signed in accounts removed at the end of the test?

[Jackie Quinn, 2016/12/22 20:09:13]

Yes, disabling mock auth is run at the end of all tests, and includes signing
out and clearing accounts.

+}
+
 // Tests that searching history displays only entries matching the search term.
 - (void)testSearchHistory {
   [self loadTestURLs];
   [self openHistoryPanel];
   [[EarlGrey selectElementWithMatcher:searchIconButton()]
       performAction:grey_tap()];
 
   NSString* searchString =
       [NSString stringWithFormat:@"%s", _URL1.path().c_str()];
   [[EarlGrey selectElementWithMatcher:grey_keyWindow()]
@@ skipping 205 matching lines @@
 - (void)resetBrowsingDataPrefs {
   PrefService* prefs = chrome_test_util::GetOriginalBrowserState()->GetPrefs();
   prefs->ClearPref(browsing_data::prefs::kDeleteBrowsingHistory);
   prefs->ClearPref(browsing_data::prefs::kDeleteCookies);
   prefs->ClearPref(browsing_data::prefs::kDeleteCache);
   prefs->ClearPref(browsing_data::prefs::kDeletePasswords);
   prefs->ClearPref(browsing_data::prefs::kDeleteFormData);
 }
 
 @end