Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 259873002: Calculate an expected number of visible destinations more accurately to prevent extra (and unnecess… (Closed)

Created:
6 years, 8 months ago by Aleksey Shlyapnikov
Modified:
6 years, 7 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Calculate an expected number of visible destinations more accurately to prevent extra (and unnecessary) destination search window resize. In some cases, since select control dropdown is not moved along with the control, close the select element on destination select window resize to keep UI consistent. BUG=363557 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -26 lines) Patch
M chrome/browser/resources/print_preview/search/destination_list.css View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/resources/print_preview/search/destination_list.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/search/destination_list.js View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/resources/print_preview/search/destination_search.js View 1 chunk +37 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Aleksey Shlyapnikov
6 years, 8 months ago (2014-04-25 18:26:28 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 8 months ago (2014-04-25 22:21:32 UTC) #2
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 8 months ago (2014-04-25 22:23:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/259873002/1
6 years, 8 months ago (2014-04-25 22:27:47 UTC) #4
Sergey Berezin
The CQ bit was unchecked by sergeyberezin@chromium.org
6 years, 7 months ago (2014-04-28 16:26:55 UTC) #5
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
6 years, 7 months ago (2014-04-28 16:26:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/259873002/1
6 years, 7 months ago (2014-04-28 16:27:26 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 16:39:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_dbg_triggered_tests
6 years, 7 months ago (2014-04-28 16:39:15 UTC) #9
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 7 months ago (2014-04-28 18:00:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/259873002/1
6 years, 7 months ago (2014-04-28 18:02:09 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 18:05:44 UTC) #12
Message was sent while issue was closed.
Change committed as 266604

Powered by Google App Engine
This is Rietveld 408576698