Local salient image storage for enhanced bookmark experiment.

components/components_tests.gyp

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # This turns on e.g. the filename-based detection of which
     # platforms to include source files on (e.g. files ending in
     # _mac.h or _mac.cc are only compiled on MacOSX).
     'chromium_code': 1,
@@ skipping 47 matching lines @@
             'autofill/core/browser/validation_unittest.cc',
             'autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc',
             'autofill/core/browser/webdata/autofill_table_unittest.cc',
             'autofill/core/browser/webdata/web_data_service_unittest.cc',
             'autofill/core/common/form_data_unittest.cc',
             'autofill/core/common/form_field_data_unittest.cc',
             'autofill/core/common/password_form_fill_data_unittest.cc',
             'autofill/core/common/save_password_progress_logger_unittest.cc',
             'bookmarks/core/browser/bookmark_codec_unittest.cc',
             'bookmarks/core/test/bookmark_index_unittest.cc',
+            'bookmarks_enhanced/image_store_unittest.cc',
             'captive_portal/captive_portal_detector_unittest.cc',
             'cloud_devices/common/cloud_devices_urls_unittest.cc',
             'cloud_devices/common/printer_description_unittest.cc',
             'data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler_unittest.cc',
             'data_reduction_proxy/browser/data_reduction_proxy_config_service_unittest.cc',
             'data_reduction_proxy/browser/data_reduction_proxy_metrics_unittest.cc',
             'data_reduction_proxy/browser/data_reduction_proxy_settings_unittest.cc',
             'data_reduction_proxy/browser/http_auth_handler_data_reduction_proxy_unittest.cc',
             'dom_distiller/core/article_entry_unittest.cc',
             'dom_distiller/core/distiller_unittest.cc',
@@ skipping 119 matching lines @@
             # Dependencies of autofill
             'components.gyp:autofill_core_browser',
             'components.gyp:autofill_core_common',
             'components.gyp:autofill_core_test_support',
             'components_strings.gyp:components_strings',
             '../third_party/libphonenumber/libphonenumber.gyp:libphonenumber',
 
             # Dependencies of bookmarks
             'components.gyp:bookmarks_core_browser',
             'components.gyp:bookmarks_core_test_support',
-            
+
+            # Dependencies of bookmarks_enhanced
+            'components.gyp:bookmarks_enhanced_test_support',

[blundell, 2014/05/09 08:17:48]

Add components.gyp:bookmarks_enhanced as well

[Kibeom Kim (inactive), 2014/05/09 09:44:41]

Done.

+
             # Dependencies of captive_portal
             'components.gyp:captive_portal_test_support',
             '../net/net.gyp:net_test_support',
 
             # Dependencies of cloud_devices
             'components.gyp:cloud_devices_common',
 
             # Dependencies of data_reduction_proxy
             'components.gyp:data_reduction_proxy_browser',
             'components.gyp:data_reduction_proxy_common',
@@ skipping 108 matching lines @@
                 'components.gyp:web_modal_test_support',
               ],
             }, { # 'OS == "ios"'
               'includes': ['../chrome/chrome_ios_bundle_resources.gypi'],
               'sources/': [
                 ['exclude', '\\.cc$'],
                 ['exclude', '\\.mm$'],
                 ['include', '^test/run_all_unittests\\.cc$'],
                 ['include', '^auto_login_parser/'],
                 ['include', '^autofill/core/'],
                 ['include', '^bookmarks/'],

[blundell, 2014/05/09 08:17:48]

Add bookmarks_enhanced here.

[Kibeom Kim (inactive), 2014/05/09 09:44:41]

I'll do as a follow-up ios CL. This CL doesn't assume ios usage.

                 ['include', '^data_reduction_proxy/'],
                 ['include', '^dom_distiller/'],
                 ['include', '^json_schema/'],
                 ['include', '^keyed_service/core/'],
                 ['include', '^language_usage_metrics/'],
                 ['include', '^password_manager/'],
                 ['include', '^precache/core/'],
                 ['include', '^search_provider_logos/'],
                 ['include', '^signin/'],
                 ['include', '^sync_driver/'],
                 ['include', '^translate/'],
                 ['include', '^variations/'],
               ],
+              'sources!': [
+                'bookmarks_enhanced/image_store_unittest.cc',

[blundell, 2014/05/09 08:17:48]

Why is this file being excluded on iOS? Should there be a TODO and bug reference
here?

[Kibeom Kim (inactive), 2014/05/09 09:44:41]

Done.

+              ],
               'dependencies': [
                 # Dependencies of signin
                 'components.gyp:signin_ios_browser',
                 '../ios/ios_tests.gyp:test_support_ios',
               ],
               'actions': [
                 {
                   'action_name': 'copy_test_data',
                   'variables': {
                     'test_data_files': [
@@ skipping 336 matching lines @@
               'dependencies': [
                 '../base/allocator/allocator.gyp:allocator',
               ],
             }],
           ],
         },
       ],
     }],
   ],
 }