components/bookmarks_enhanced.gypi - Issue 259863007: Local salient image storage for enhanced bookmark experiment.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/bookmarks_enhanced.gypi

Issue 259863007: Local salient image storage for enhanced bookmark experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unneeded header include Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 'target_name': 'bookmarks_enhanced',

	9 'type': 'static_library',

	10 'include_dirs': [

	11 '..',

	12 ],

	13 'dependencies': [

	14 '../base/base.gyp:base',

	15 '../sql/sql.gyp:sql',

	16 '../ui/gfx/gfx.gyp:gfx',

	17 '../url/url.gyp:url_lib',

	18 ],

	19 'sources': [

	20 'bookmarks_enhanced/image_store.h',
	tfarina 2014/05/08 15:41:08 fix indentation here, only two spaces from ' fix indentation here, only two spaces from ' Kibeom Kim (inactive) 2014/05/08 17:56:33 Done. Show quoted text On 2014/05/08 15:41:08, tfarina wrote: > fix indentation here, only two spaces from ' Done.
	21 'bookmarks_enhanced/image_store.cc',

	22 'bookmarks_enhanced/image_store_util.h',

	23 'bookmarks_enhanced/persistent_image_store.cc',

	24 'bookmarks_enhanced/persistent_image_store.h',

	25 ],

	26 'conditions': [

	27 ['OS!="ios"', {
	tfarina 2014/05/08 15:41:08 what if you invert that check? OS == ios and do so what if you invert that check? OS == ios and do sources! and keep listing image_store_util.cc above? Kibeom Kim (inactive) 2014/05/08 17:56:33 Done. Show quoted text On 2014/05/08 15:41:08, tfarina wrote: > what if you invert that check? OS == ios and do sources! and keep listing > image_store_util.cc above? Done.
	28 'sources': [

	29 'bookmarks_enhanced/image_store_util.cc',

	30 ],

	31 }],

	32 ],

	33 },

	34 ],

	35 }

OLD	NEW

« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/bookmarks_enhanced/DEPS » ('j') | components/bookmarks_enhanced/DEPS » ('J')