Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Side by Side Diff: components/bookmarks_enhanced/image_store_util_android.cc

Issue 259863007: Local salient image storage for enhanced bookmark experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed from NonThreadSafe to ThreadChecker Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/bookmarks_enhanced/image_store_util.h"
6
7 namespace image_store_util {
8
9 scoped_refptr<base::RefCountedMemory> BytesForImage(gfx::Image image) {
10 return image.As1xPNGBytes();
sky 2014/05/06 16:14:20 How come you only store the 1x image? Shouldn't yo
Kibeom Kim (inactive) 2014/05/07 09:56:30 I thought about it. Since this is a local image ca
sky 2014/05/07 16:25:30 Might a particular platform end up with more than
Kibeom Kim (inactive) 2014/05/08 00:02:19 ptal. Yes actually, on Android, we'll be feeding
11 }
12
13 gfx::Image ImageForBytes(const scoped_refptr<base::RefCountedMemory>& bytes) {
14 return gfx::Image::CreateFrom1xPNGBytes(bytes->front(), bytes->size());
15 }
16
17 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698