Issue 2598603002: Revert "Turn the VM's dart:typed_data into a patch"

Issue 2598603002: Revert "Turn the VM's dart:typed_data into a patch" (Closed)

Created:
4 years ago by Kevin Millikin (Google)

Modified:
4 years ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Turn the VM's dart:typed_data into a patch" This reverts commit a9b906d319c32525a0600c75c008c92753591d86. A lot of things were broken by the changes to implementation class names. BUG= Committed: https://github.com/dart-lang/sdk/commit/f97440848f2132d4c1953cd99fbbbc5f8cc812d1

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2049 lines, -4053 lines)			Patch
A +	runtime/lib/typed_data.dart	View	68 chunks	+1843 lines, -683 lines	0 comments	Download
D	runtime/lib/typed_data_patch.dart	View	1 chunk	+0 lines, -3098 lines	0 comments	Download
M	runtime/lib/typed_data_sources.gypi	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	2 chunks	+28 lines, -28 lines	0 comments	Download
M	runtime/observatory/tests/service/get_object_rpc_test.dart	View	8 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/vm/BUILD.gn	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/bootstrap.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/bootstrap.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	runtime/vm/gypi_contents.gni	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/method_recognizer.h	View	3 chunks	+95 lines, -104 lines	0 comments	Download
M	runtime/vm/object.cc	View	5 chunks	+13 lines, -10 lines	0 comments	Download
M	runtime/vm/precompiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/profiler_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/symbols.h	View	2 chunks	+19 lines, -19 lines	0 comments	Download
M	runtime/vm/vm.gypi	View	9 chunks	+10 lines, -78 lines	0 comments	Download
M	tools/patch_sdk.dart	View	1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Kevin Millikin (Google)

Committed patchset #1 (id:1) manually as f97440848f2132d4c1953cd99fbbbc5f8cc812d1 (presubmit successful).

4 years ago (2016-12-21 11:28:40 UTC) #4

Message was sent while issue was closed.

LGTM.