Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: pkg/analyzer/lib/src/command_line/arguments.dart

Issue 2598593003: support --options flag and other analysis options flags in DDC (Closed)
Patch Set: add missing tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/command_line/arguments.dart
diff --git a/pkg/analyzer/lib/src/command_line/arguments.dart b/pkg/analyzer/lib/src/command_line/arguments.dart
index 5ea958eaad61039d80ed01c1b813ad1fd3ed6675..03953d2ffe68270cf3ef6914e068caec7dac65ab 100644
--- a/pkg/analyzer/lib/src/command_line/arguments.dart
+++ b/pkg/analyzer/lib/src/command_line/arguments.dart
@@ -119,7 +119,7 @@ void defineAnalysisArguments(ArgParser parser, {bool hide: true, ddc: false}) {
help: 'The path to the Dart SDK summary file.', hide: hide);
parser.addOption(analysisOptionsFileOption,
- help: 'Path to an analysis options file.', hide: ddc);
+ help: 'Path to an analysis options file.');
parser.addOption(packageRootOption,
abbr: 'p',
@@ -133,16 +133,13 @@ void defineAnalysisArguments(ArgParser parser, {bool hide: true, ddc: false}) {
parser.addFlag(strongModeFlag,
help: 'Enable strong static checks (https://goo.gl/DqcBsw)',
- defaultsTo: ddc,
- hide: ddc);
+ defaultsTo: ddc);
parser.addFlag(noImplicitCastsFlag,
negatable: false,
- help: 'Disable implicit casts in strong mode (https://goo.gl/cTLz40)',
- hide: ddc);
+ help: 'Disable implicit casts in strong mode (https://goo.gl/cTLz40)');
parser.addFlag(noImplicitDynamicFlag,
negatable: false,
- help: 'Disable implicit dynamic (https://goo.gl/m0UgXD)',
- hide: ddc);
+ help: 'Disable implicit dynamic (https://goo.gl/m0UgXD)');
//
// Hidden flags and options.
//
@@ -155,7 +152,7 @@ void defineAnalysisArguments(ArgParser parser, {bool hide: true, ddc: false}) {
help: 'Fix issue 21938.',
defaultsTo: false,
negatable: false,
- hide: hide || ddc);
+ hide: hide);
parser.addFlag(enableInitializingFormalAccessFlag,
help:
'Enable support for allowing access to field formal parameters in a '
@@ -167,7 +164,7 @@ void defineAnalysisArguments(ArgParser parser, {bool hide: true, ddc: false}) {
help: 'Relax restrictions on mixins (DEP 34).',
defaultsTo: false,
negatable: false,
- hide: hide || ddc);
+ hide: hide);
// parser.addFlag('enable_type_checks',
// help: 'Check types in constant evaluation.',
// defaultsTo: false,
« no previous file with comments | « no previous file | pkg/dev_compiler/lib/src/analyzer/context.dart » ('j') | pkg/dev_compiler/lib/src/analyzer/context.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698