support --options flag and other analysis options flags in DDC

pkg/dev_compiler/lib/src/compiler/compiler.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashSet, Queue;
 import 'dart:convert' show BASE64, JSON, UTF8;
 import 'dart:io' show File;
 import 'package:analyzer/dart/element/element.dart' show LibraryElement;
 import 'package:analyzer/analyzer.dart'
     show AnalysisError, CompilationUnit, ErrorSeverity;
 import 'package:analyzer/file_system/file_system.dart' show ResourceProvider;
+import 'package:analyzer/file_system/physical_file_system.dart'
+    show PhysicalResourceProvider;
+import 'package:analyzer/src/context/builder.dart' show ContextBuilder;
+import 'package:analyzer/src/context/context.dart' show AnalysisContextImpl;
 import 'package:analyzer/src/generated/engine.dart'
-    show AnalysisContext, AnalysisEngine;
-import 'package:analyzer/src/generated/source.dart' show DartUriResolver;
+    show AnalysisContext, AnalysisEngine, AnalysisOptionsImpl;
+import 'package:analyzer/src/generated/sdk.dart' show DartSdkManager;
+import 'package:analyzer/src/generated/source.dart'
+    show ContentCache, DartUriResolver;
 import 'package:analyzer/src/generated/source_io.dart'
     show Source, SourceKind, UriResolver;
 import 'package:analyzer/src/summary/package_bundle_reader.dart'
     show InSummarySource, InputPackagesResultProvider, SummaryDataStore;
 import 'package:analyzer/src/error/codes.dart' show StaticTypeWarningCode;
 import 'package:args/args.dart' show ArgParser, ArgResults;
 import 'package:args/src/usage_exception.dart' show UsageException;
 import 'package:func/func.dart' show Func1;
 import 'package:path/path.dart' as path;
 import 'package:source_maps/source_maps.dart';
 
-import '../analyzer/context.dart'
-    show
-        AnalyzerOptions,
-        createAnalysisContext,
-        createSdkPathResolver,
-        createSourceFactory;
+import '../analyzer/context.dart' show AnalyzerOptions, createSourceFactory;
 import '../js_ast/js_ast.dart' as JS;
 import 'code_generator.dart' show CodeGenerator;
 import 'error_helpers.dart' show errorSeverity, formatError, sortErrors;
 import 'extension_types.dart' show ExtensionTypeSet;
 import 'js_names.dart' as JS;
 import 'module_builder.dart' show transformModuleFormat, ModuleFormat;
 import 'source_map_printer.dart' show SourceMapPrintingContext;
 
 /// Compiles a set of Dart files into a single JavaScript module.
 ///
@@ skipping 10 matching lines @@
 ///
 /// For all other files, it is up to the [AnalysisContext] to decide whether or
 /// not any caching is performed. By default an analysis context will assume
 /// sources are immutable for the life of the context, and cache information
 /// about them.
 class ModuleCompiler {
   final AnalysisContext context;
   final SummaryDataStore summaryData;
   final ExtensionTypeSet _extensionTypes;
 
-  ModuleCompiler.withContext(AnalysisContext context, this.summaryData)
+  ModuleCompiler._(AnalysisContext context, this.summaryData)
       : context = context,
-        _extensionTypes = new ExtensionTypeSet(context) {
-    if (!context.analysisOptions.strongMode) {
-      throw new ArgumentError('AnalysisContext must be strong mode');
-    }
-    if (!context.sourceFactory.dartSdk.context.analysisOptions.strongMode) {
-      throw new ArgumentError('AnalysisContext must have strong mode SDK');
-    }
-  }
+        _extensionTypes = new ExtensionTypeSet(context);
 
-  factory ModuleCompiler(AnalyzerOptions options,
-      {DartUriResolver sdkResolver,
-      ResourceProvider resourceProvider,
-      List<UriResolver> fileResolvers}) {
+  factory ModuleCompiler(String projRoot, AnalyzerOptions options,
+      {ResourceProvider resourceProvider, List<UriResolver> fileResolvers}) {
     AnalysisEngine.instance.processRequiredPlugins();
 
-    sdkResolver ??=
-        createSdkPathResolver(options.dartSdkSummaryPath, options.dartSdkPath);
+    resourceProvider ??= PhysicalResourceProvider.INSTANCE;
+
+    var contextBuilder = new ContextBuilder(resourceProvider,
+        new DartSdkManager(options.dartSdkPath, true), new ContentCache(),
+        options: options.contextBuilderOptions);
+
+    var analysisOptions = contextBuilder.getAnalysisOptions(projRoot);

[vsm, 2017/01/03 17:56:28]

Hmm, looks like this is the library-root being passed in as the place to get the
analysis options file?

[danrubel, 2017/01/03 18:51:48]

Correct. It will start looking in the projRoot directory (the library-root) and
up the parent tree until one is found.

+    (analysisOptions as AnalysisOptionsImpl)
+      ..strongMode = true

[vsm, 2017/01/03 17:56:28]

Why do we need to set this here and in the context file?

[danrubel, 2017/01/03 18:51:48]

Hmmm... good point. Removed.

And I moved trackCacheDependencies into the context file alongside strongMode.

+      ..trackCacheDependencies = false;
+    var sdk = contextBuilder.findSdk(null, analysisOptions);
+
+    var sdkResolver = new DartUriResolver(sdk);
 
     // Read the summaries.
     var summaryData =
         new SummaryDataStore(options.summaryPaths, recordDependencyInfo: true);
 
     var srcFactory = createSourceFactory(options,
         sdkResolver: sdkResolver,
         fileResolvers: fileResolvers,
         summaryData: summaryData,
         resourceProvider: resourceProvider);
 
-    var context = createAnalysisContext();
+    var context =
+        AnalysisEngine.instance.createAnalysisContext() as AnalysisContextImpl;
+    context.analysisOptions = analysisOptions;
     context.sourceFactory = srcFactory;
     context.typeProvider = sdkResolver.dartSdk.context.typeProvider;
     context.resultProvider =
         new InputPackagesResultProvider(context, summaryData);
     options.declaredVariables.forEach(context.declaredVariables.define);
     context.declaredVariables.define('dart.isVM', 'false');
 
     // TODO(vsm): Should this be hardcoded?
     context.declaredVariables.define('dart.library.html', 'true');
     context.declaredVariables.define('dart.library.io', 'false');
 
-    return new ModuleCompiler.withContext(context, summaryData);
+    if (!context.analysisOptions.strongMode) {
+      throw new ArgumentError('AnalysisContext must be strong mode');
+    }
+    if (!context.sourceFactory.dartSdk.context.analysisOptions.strongMode) {
+      throw new ArgumentError('AnalysisContext must have strong mode SDK');
+    }
+
+    return new ModuleCompiler._(context, summaryData);
   }
 
   bool _isFatalError(AnalysisError e, CompilerOptions options) {
     if (errorSeverity(context, e) != ErrorSeverity.ERROR) return false;
 
     // These errors are not fatal in the REPL compile mode as we
     // allow access to private members across library boundaries
     // and those accesses will show up as undefined members unless
     // additional analyzer changes are made to support them.
     // TODO(jacobr): consider checking that the identifier name
@@ skipping 443 matching lines @@
     // Fall back to a relative path.
     return path.toUri(path.relative(path.fromUri(uri), from: dir)).toString();
   }
 
   for (int i = 0; i < list.length; i++) {
     list[i] = transformUri(list[i]);
   }
   map['file'] = transformUri(map['file']);
   return map;
 }