Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: src/compiler/access-info.cc

Issue 2598543003: [runtime][ic] Constant field tracking support. (Closed)
Patch Set: Addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <ostream> 5 #include <ostream>
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/compilation-dependencies.h" 8 #include "src/compilation-dependencies.h"
9 #include "src/compiler/access-info.h" 9 #include "src/compiler/access-info.h"
10 #include "src/compiler/type-cache.h" 10 #include "src/compiler/type-cache.h"
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 return true; 343 return true;
344 } else { 344 } else {
345 DCHECK_EQ(kAccessor, details.kind()); 345 DCHECK_EQ(kAccessor, details.kind());
346 // TODO(turbofan): Add support for general accessors? 346 // TODO(turbofan): Add support for general accessors?
347 return false; 347 return false;
348 } 348 }
349 349
350 } else { 350 } else {
351 DCHECK_EQ(kDescriptor, details.location()); 351 DCHECK_EQ(kDescriptor, details.location());
352 if (details.kind() == kData) { 352 if (details.kind() == kData) {
353 DCHECK(!FLAG_track_constant_fields);
353 *access_info = PropertyAccessInfo::DataConstant( 354 *access_info = PropertyAccessInfo::DataConstant(
354 MapList{receiver_map}, 355 MapList{receiver_map},
355 handle(descriptors->GetValue(number), isolate()), holder); 356 handle(descriptors->GetValue(number), isolate()), holder);
356 return true; 357 return true;
357 } else { 358 } else {
358 DCHECK_EQ(kAccessor, details.kind()); 359 DCHECK_EQ(kAccessor, details.kind());
359 Handle<Object> accessors(descriptors->GetValue(number), isolate()); 360 Handle<Object> accessors(descriptors->GetValue(number), isolate());
360 if (!accessors->IsAccessorPair()) return false; 361 if (!accessors->IsAccessorPair()) return false;
361 Handle<Object> accessor( 362 Handle<Object> accessor(
362 access_mode == AccessMode::kLoad 363 access_mode == AccessMode::kLoad
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 } 570 }
570 return false; 571 return false;
571 } 572 }
572 573
573 574
574 Factory* AccessInfoFactory::factory() const { return isolate()->factory(); } 575 Factory* AccessInfoFactory::factory() const { return isolate()->factory(); }
575 576
576 } // namespace compiler 577 } // namespace compiler
577 } // namespace internal 578 } // namespace internal
578 } // namespace v8 579 } // namespace v8
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698