Issue 259843004: Remove some NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED from c/b/extensions Part2

Issue 259843004: Remove some NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED from c/b/extensions Part2 (Closed)

Created:
6 years, 8 months ago by limasdf

Modified:
6 years, 7 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove some NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED from c/b/extensions Part2 BUG=354046, 354458 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266649

Patch Set 3 : address review comment #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+208 lines, -158 lines)			Patch
M	chrome/browser/extensions/active_tab_unittest.cc	View		2 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/api/input_ime/input_ime_api.h	View	1	5 chunks	+16 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/api/input_ime/input_ime_api.cc	View	1	3 chunks	+36 lines, -45 lines	0 comments	Download
M	chrome/browser/extensions/api/log_private/filter_handler.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/log_private/log_private_api.h	View	1	3 chunks	+15 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc	View	1	6 chunks	+13 lines, -18 lines	0 comments	Download
M	chrome/browser/extensions/extension_infobar_delegate.h	View		4 chunks	+17 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_infobar_delegate.cc	View		3 chunks	+16 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/extension_toolbar_model.h	View		4 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_toolbar_model.cc	View		4 chunks	+27 lines, -28 lines	0 comments	Download
M	chrome/browser/extensions/external_install_ui.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/external_install_ui.cc	View	1 2	8 chunks	+44 lines, -23 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm https://codereview.chromium.org/259843004/diff/250001/chrome/browser/extensions/external_install_ui.cc File chrome/browser/extensions/external_install_ui.cc (right): https://codereview.chromium.org/259843004/diff/250001/chrome/browser/extensions/external_install_ui.cc#newcode428 chrome/browser/extensions/external_install_ui.cc:428: if (extension != extension_) simpler would be to ...

6 years, 7 months ago (2014-04-28 16:28:10 UTC) #2

limasdf

Thanks for the review https://codereview.chromium.org/259843004/diff/250001/chrome/browser/extensions/external_install_ui.cc File chrome/browser/extensions/external_install_ui.cc (right): https://codereview.chromium.org/259843004/diff/250001/chrome/browser/extensions/external_install_ui.cc#newcode428 chrome/browser/extensions/external_install_ui.cc:428: if (extension != extension_) On ...

6 years, 7 months ago (2014-04-28 16:32:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/259843004/270001

6 years, 7 months ago (2014-04-28 16:32:31 UTC) #5

Message was sent while issue was closed.

Change committed as 266649

Expand Messages | Collapse Messages