third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h - Issue 2598393002: Do not skip ink for ideographic scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

Issue 2598393002: Do not skip ink for ideographic scripts (Closed)

Patch Set: drott review Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/fonts/GlyphBuffer.h ('K') | « third_party/WebKit/Source/platform/fonts/GlyphBuffer.h ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp » ('j') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

index b48e4553fb72793e8fe1ec99cdd1d8d3d48916f2..9fd86f0923bfb10ad2d3b8ad7ed8f448ae89b93c 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

@@ -51,11 +51,12 @@ class ShapeResultBuffer {

float totalWidth) const;

private:

- float fillFastHorizontalGlyphBuffer(GlyphBuffer*, TextDirection) const;

+ float fillFastHorizontalGlyphBuffer(GlyphBuffer*, const TextRun&) const;

template <TextDirection>

static float fillGlyphBufferForRun(GlyphBuffer*,

const ShapeResult::RunInfo*,

+ const TextRun&,

float initialAdvance,

unsigned from,

unsigned to,