Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: third_party/WebKit/Source/platform/fonts/GlyphBuffer.h

Issue 2598393002: Do not skip ink for ideographic scripts (Closed)
Patch Set: drott review Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/GlyphBuffer.h
diff --git a/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h b/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h
index f05a0d5ad37ac87f4aa576a7161b1a416c8aaee5..350b6fed3900639f83a1e0e18715acf217cbf205 100644
--- a/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h
+++ b/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h
@@ -141,6 +141,17 @@ class GlyphBuffer {
m_offsets.reverse();
}
+ void saveSkipInkExceptions() {
+ m_saveSkipInkExceptions = true;
+ m_skipInkExceptions.reserveInitialCapacity(2048);
+ }
+
+ bool shouldSaveSkipInkExceptions() const { return m_saveSkipInkExceptions; }
+
+ void addIsSkipInkException(bool value) { m_skipInkExceptions.append(value); }
drott 2017/01/02 15:07:46 Can we add a DCHECK_EQ(m_offsets.size(), m_skipInk
+
+ Vector<bool>& skipInkExceptions() { return m_skipInkExceptions; }
drott 2017/01/02 15:07:46 Can we add the same debug assertion here, before r
+
protected:
Vector<const SimpleFontData*, 2048> m_fontData;
Vector<Glyph, 2048> m_glyphs;
@@ -149,6 +160,10 @@ class GlyphBuffer {
// (depending on the buffer-wide positioning mode). This matches the
// glyph positioning format used by Skia.
Vector<float, 2048> m_offsets;
+
+ Vector<bool> m_skipInkExceptions;
drott 2017/01/02 15:07:46 Could you add a comment like: // Flag vector of id
+
+ bool m_saveSkipInkExceptions = false;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698