Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 25982005: Relands: Android perf tests: kill adbd on the device after running a test. (Closed)

Created:
7 years, 2 months ago by bulach
Modified:
7 years, 2 months ago
Reviewers:
navabi, rmcilroy
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, navabi1, craigdh
Visibility:
Public.

Description

Relands: Android perf tests: kill adbd on the device after running a test. There's some data indicating that adbd on the device sometimes spontaneously restores its connection. After running a test, let's kill adbd and forwarder and wait for bit. This is a speculative change to try to make the bots healthier. Relands crrev.com/226762: will also kill the forwarder. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M build/android/pylib/android_commands.py View 1 chunk +8 lines, -0 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
ptal, second attempt :)
7 years, 2 months ago (2013-10-04 12:16:48 UTC) #1
rmcilroy
lgtm Worth a go. Fingers crossed!
7 years, 2 months ago (2013-10-04 13:59:19 UTC) #2
bulach
(navabi craigdh FYI) thanks! CQing..
7 years, 2 months ago (2013-10-04 15:05:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/25982005/1
7 years, 2 months ago (2013-10-04 15:06:41 UTC) #4
commit-bot: I haz the power
Change committed as 227038
7 years, 2 months ago (2013-10-04 18:14:41 UTC) #5
navabi
7 years, 2 months ago (2013-10-04 19:01:08 UTC) #6
Message was sent while issue was closed.
On 2013/10/04 18:14:41, I haz the power (commit-bot) wrote:
> Change committed as 227038

post-commit lgtm. Thanks Marcus for trying this!

Powered by Google App Engine
This is Rietveld 408576698