Add a Presubmit to check if a file must be included or imported.

PRESUBMIT_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 import subprocess
 import unittest
 
 import PRESUBMIT
 from PRESUBMIT_test_mocks import MockChange, MockFile, MockAffectedFile
 from PRESUBMIT_test_mocks import MockInputApi, MockOutputApi
 
 _TEST_DATA_DIR = 'base/test/data/presubmit'
 
+class IncludeImportTest(unittest.TestCase):
+  def testDetectObjectiveCHeaderInterface(self):
+    content = ['# Copyright line',
+               '',
+               '@interface Class']
+    mock_input_api = MockInputApi()
+    mock_name = 'some/ios/foo.h'
+    mock_file = MockFile(mock_name, content)
+    (detection_ok, is_objc) = \
+        PRESUBMIT._CheckHeaderIsObjectiveC(mock_input_api, mock_name, mock_file)
+    self.assertEqual(detection_ok, True)
+    self.assertEqual(is_objc, True)
+
+  def testDetectObjectiveCNotIosMacFile(self):
+    content = ['# Copyright line',
+               '',
+               '@interface Class']
+    mock_input_api = MockInputApi()
+    mock_name = 'some/bar/foo.h'
+    mock_file = MockFile(mock_name, content)
+    (detection_ok, is_objc) = \
+        PRESUBMIT._CheckHeaderIsObjectiveC(mock_input_api, mock_name, mock_file)
+    self.assertEqual(detection_ok, False)
+    self.assertEqual(is_objc, False)
+
+
+  def testDetectObjectiveCBlock(self):
+    content = ['# Copyright line',
+               '',
+               'typedef void (^ProceduralBlock)(void);']
+    mock_input_api = MockInputApi()
+    mock_name = 'some/path/foo_mac.h'
+    mock_file = MockFile(mock_name, content)
+    (detection_ok, is_objc) = \
+        PRESUBMIT._CheckHeaderIsObjectiveC(mock_input_api, mock_name, mock_file)
+    self.assertEqual(detection_ok, True)
+    self.assertEqual(is_objc, True)
+
+  def testDetectObjectiveCImport(self):
+    content = ['# Copyright line',
+               '',
+               '#include "foo.h',
+               '#include "bar.h',
+               '#import "example.h',
+               '#include "chromium.h']
+    mock_input_api = MockInputApi()
+    mock_name = 'some/mac/foo.h'
+    mock_file = MockFile(mock_name, content)
+    (detection_ok, is_objc) = \
+        PRESUBMIT._CheckHeaderIsObjectiveC(mock_input_api, mock_name, mock_file)
+    self.assertEqual(detection_ok, True)
+    self.assertEqual(is_objc, True)
+
+  def testDetectObjectiveCHeaderCPlusPlus(self):
+    content = ['# Copyright line',
+               '',
+               '#include <cstdio>',
+               'class Foo']
+    mock_input_api = MockInputApi()
+    mock_name = 'some/path/foo_ios.h'
+    mock_file = MockFile(mock_name, content)
+    (detection_ok, is_objc) = \
+        PRESUBMIT._CheckHeaderIsObjectiveC(mock_input_api, mock_name, mock_file)
+    self.assertEqual(detection_ok, True)
+    self.assertEqual(is_objc, False)
+
+  def testDetectObjectiveCHeaderCPlusPlus(self):
+    content = ['# Copyright line',
+               '',
+               '#if !defined(__OBJC__)',
+               '#error "ObjectiveC required"',
+               '#endif',
+               '',
+               '#include <cstdio>',
+               'class Foo']
+    mock_input_api = MockInputApi()
+    mock_name = 'ios/path/foo.h'
+    mock_file = MockFile(mock_name, content)
+    (detection_ok, is_objc) = \
+        PRESUBMIT._CheckHeaderIsObjectiveC(mock_input_api, mock_name, mock_file)
+    self.assertEqual(detection_ok, True)
+    self.assertEqual(is_objc, True)
+
+  def testDetectObjectiveCNoObjcGuard(self):
+    content = ['# Copyright line',
+               '',
+               '#if !defined(__OBJC__)',
+               '#include "foo.h"',
+               '#else',
+               '#import "foo.h"',
+               '#endif']
+    mock_input_api = MockInputApi()
+    mock_name = 'mac/path/foo.h'
+    mock_file = MockFile(mock_name, content)
+    (detection_ok, is_objc) = \
+        PRESUBMIT._CheckHeaderIsObjectiveC(mock_input_api, mock_name, mock_file)
+    self.assertEqual(detection_ok, False)
+
+
+  def testDetectObjectiveCNoObjcGuard(self):
+    content = ['# Copyright line',
+               '',
+               '#if defined(__OBJC__)',
+               '#import "foo.h"',
+               '#else',
+               '#include "foo.h"',
+               '#endif']
+    mock_input_api = MockInputApi()
+    mock_name = 'some/path_ios/foo.h'
+    mock_file = MockFile(mock_name, content)
+    (detection_ok, is_objc) = \
+        PRESUBMIT._CheckHeaderIsObjectiveC(mock_input_api, mock_name, mock_file)
+    self.assertEqual(detection_ok, False)
+
 class IncludeOrderTest(unittest.TestCase):
   def testSystemHeaderOrder(self):
     scope = [(1, '#include <csystem.h>'),
              (2, '#include <cppsystem>'),
              (3, '#include "acustom.h"')]
     all_linenums = [linenum for (linenum, _) in scope]
     mock_input_api = MockInputApi()
     warnings = PRESUBMIT._CheckIncludeOrderForScope(scope, mock_input_api,
                                                     '', all_linenums)
     self.assertEqual(0, len(warnings))
@@ skipping 1270 matching lines @@
     mock_input_api.files = [
       MockAffectedFile('chrome/browser/resources/blah.js', 'arrow => OK here'),
     ]
     warnings = PRESUBMIT._CheckForRiskyJsFeatures(
         mock_input_api, MockOutputApi())
     self.assertEqual(0, len(warnings))
 
 
 if __name__ == '__main__':
   unittest.main()