Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1763)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

Issue 2598163002: WebContentsObserver update for PlzNavigate methods (Closed)
Patch Set: AW fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
index f13b2897fcf7d36a2d6d0c40830118212f33780d..066067f0fc53b51b045156bc1928c89685433f61 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
@@ -299,8 +299,8 @@ public class OverlayPanelContent {
}
@Override
- public void didStartProvisionalLoadForFrame(long frameId, long parentFrameId,
- boolean isMainFrame, String validatedUrl, boolean isErrorPage) {
+ public void didStartNavigation(
+ String validatedUrl, boolean isMainFrame, boolean isErrorPage) {
if (isMainFrame) {
mContentDelegate.onMainFrameLoadStarted(validatedUrl,
!TextUtils.equals(validatedUrl, mLoadedUrl));
@@ -308,13 +308,15 @@ public class OverlayPanelContent {
}
@Override
- public void didNavigateMainFrame(String url, String baseUrl,
- boolean isNavigationToDifferentPage, boolean isNavigationInPage,
- int httpResultCode) {
+ public void didFinishNavigation(String validatedUrl, boolean isMainFrame,
+ boolean isErrorPage, boolean hasCommitted,
+ boolean isNavigationToDifferentPage, boolean isFragmentNavigation,
+ boolean isReload) {
+ if (!isMainFrame) return;
+
mIsProcessingPendingNavigation = false;
- mContentDelegate.onMainFrameNavigation(url,
- !TextUtils.equals(url, mLoadedUrl),
- isHttpFailureCode(httpResultCode));
+ mContentDelegate.onMainFrameNavigation(validatedUrl,
+ !TextUtils.equals(validatedUrl, mLoadedUrl), isErrorPage);
}
@Override
@@ -433,13 +435,6 @@ public class OverlayPanelContent {
}
/**
- * @return Whether the given HTTP result code represents a failure or not.
- */
- private boolean isHttpFailureCode(int httpResultCode) {
- return httpResultCode <= 0 || httpResultCode >= 400;
- }
-
- /**
* @return true if the ContentViewCore is visible on the page.
*/
public boolean isContentShowing() {

Powered by Google App Engine
This is Rietveld 408576698