Chromium Code Reviews| Index: content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java |
| diff --git a/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java b/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java |
| index c947e078e6a61e0294c718f9262f09bd2f6c62fd..ef0f43d09676235c7d8597f3fceb74fdc43dd34a 100644 |
| --- a/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java |
| +++ b/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java |
| @@ -29,18 +29,32 @@ public abstract class WebContentsObserver { |
| public void renderProcessGone(boolean wasOomProtected) {} |
| + // plzNavigate methods. |
|
Maria
2016/12/27 19:31:10
this comment is probably not necessary here. I wou
|
| + |
| + /** |
| + * Called when the browser process starts a navigation. |
| + * @param navigation The current navigation. |
| + */ |
| + public void didStartNavigation(NavigationHandle navigation) {} |
| + |
| /** |
| - * Called when the current navigation finishes. |
| - * |
| - * @param isMainFrame Whether the navigation is for the main frame. |
| - * @param isErrorPage Whether the navigation shows an error page. |
| - * @param hasCommitted Whether the navigation has committed. This returns true for either |
| - * successful commits or error pages that replace the previous page |
| - * (distinguished by |isErrorPage|), and false for errors that leave the |
| - * user on the previous page. |
| - */ |
| - public void didFinishNavigation( |
| - boolean isMainFrame, boolean isErrorPage, boolean hasCommitted) {} |
| + * Called when navigation is redirected. |
| + * @param navigation The current navigation. |
| + */ |
| + public void didRedirectNavigation(NavigationHandle navigation) {} |
| + |
| + /** |
| + * Called when the current navigation is associated with a RenderFrameHost for the first time. |
| + * @param navigation The current navigation. |
| + */ |
| + public void readyToCommitNavigation(NavigationHandle navigation) {} |
| + |
| + /** |
| + * Called when the current navigation is finished. This happens when a navigation is committed, |
| + * aborted or replaced by a new one. |
| + * @param navigation The current navigation. |
| + */ |
| + public void didFinishNavigation(NavigationHandle navigation) {} |
| /** |
| * Called when the a page starts loading. |