Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1913)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

Issue 2598163002: WebContentsObserver update for PlzNavigate methods (Closed)
Patch Set: Fixed AwWebContentsObserver Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
index 0134c19986bc752476b0721c907d638e1b5b061c..5703ec0ce6f6a2435d24d0f2e5a07490488a4fcb 100644
--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
@@ -9,6 +9,7 @@ import org.chromium.base.ObserverList.RewindableIterator;
import org.chromium.base.ThreadUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
+import org.chromium.content_public.browser.NavigationHandle;
import org.chromium.content_public.browser.WebContentsObserver;
/**
@@ -77,10 +78,33 @@ class WebContentsObserverProxy extends WebContentsObserver {
@Override
@CalledByNative
- public void didFinishNavigation(
- boolean isMainFrame, boolean isErrorPage, boolean hasCommitted) {
+ public void didStartNavigation(NavigationHandle navigation) {
for (mObserversIterator.rewind(); mObserversIterator.hasNext();) {
- mObserversIterator.next().didFinishNavigation(isMainFrame, isErrorPage, hasCommitted);
+ mObserversIterator.next().didStartNavigation(navigation);
+ }
+ }
+
+ @Override
+ @CalledByNative
+ public void didRedirectNavigation(NavigationHandle navigation) {
+ for (mObserversIterator.rewind(); mObserversIterator.hasNext();) {
+ mObserversIterator.next().didRedirectNavigation(navigation);
+ }
+ }
+
+ @Override
+ @CalledByNative
+ public void readyToCommitNavigation(NavigationHandle navigation) {
+ for (mObserversIterator.rewind(); mObserversIterator.hasNext();) {
+ mObserversIterator.next().readyToCommitNavigation(navigation);
+ }
+ }
+
+ @Override
+ @CalledByNative
+ public void didFinishNavigation(NavigationHandle navigation) {
+ for (mObserversIterator.rewind(); mObserversIterator.hasNext();) {
+ mObserversIterator.next().didFinishNavigation(navigation);
}
}

Powered by Google App Engine
This is Rietveld 408576698