content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2598163002: WebContentsObserver update for PlzNavigate methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2598163002: WebContentsObserver update for PlzNavigate methods (Closed)

Patch Set: Revert back a state CHECK Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/web_contents_observer_proxy.cc ('k') | content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index d51e32f303eb6f4bf2248e4e6e07fc28bd275303..280a618ca66f605ac9d0ec3c362be946fb8f40ed 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -146,9 +146,9 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

}

@Override

- public void didNavigateMainFrame(String url, String baseUrl,

- boolean isNavigationToDifferentPage, boolean isFragmentNavigation, int statusCode) {

- if (!isNavigationToDifferentPage) return;

+ public void didFinishNavigation(String url, boolean isInMainFrame, boolean isErrorPage,

+ boolean hasCommitted, boolean isSamePage, boolean isReload) {

+ if (!isInMainFrame || isSamePage) return;

resetPopupsAndInput();

}