Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: content/browser/android/web_contents_observer_proxy.h

Issue 2598163002: WebContentsObserver update for PlzNavigate methods (Closed)
Patch Set: Revert back a state CHECK Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/web_contents_observer_proxy.h
diff --git a/content/browser/android/web_contents_observer_proxy.h b/content/browser/android/web_contents_observer_proxy.h
index e9545b2ce561a59e8084e9d4908577f8d8657b46..dbf4b9dfc68d0370e280f87a205a944e9ddcc0a6 100644
--- a/content/browser/android/web_contents_observer_proxy.h
+++ b/content/browser/android/web_contents_observer_proxy.h
@@ -32,29 +32,26 @@ class WebContentsObserverProxy : public WebContentsObserver {
private:
void RenderViewReady() override;
void RenderProcessGone(base::TerminationStatus termination_status) override;
- void DidFinishNavigation(NavigationHandle* navigation_handle) override;
void DidStartLoading() override;
void DidStopLoading() override;
- void DidFailProvisionalLoad(RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- int error_code,
- const base::string16& error_description,
- bool was_ignored_by_handler) override;
void DidFailLoad(RenderFrameHost* render_frame_host,
const GURL& validated_url,
int error_code,
const base::string16& error_description,
bool was_ignored_by_handler) override;
- void DidNavigateMainFrame(const LoadCommittedDetails& details,
- const FrameNavigateParams& params) override;
- void DidNavigateAnyFrame(RenderFrameHost* render_frame_host,
- const LoadCommittedDetails& details,
- const FrameNavigateParams& params) override;
void DocumentAvailableInMainFrame() override;
void DidFirstVisuallyNonEmptyPaint() override;
void WasShown() override;
void WasHidden() override;
void TitleWasSet(NavigationEntry* entry, bool explicit_set) override;
+
+ // PlzNavigate methods.
+ void DidStartNavigation(NavigationHandle* navigation_handle) override;
+ void DidFinishNavigation(NavigationHandle* navigation_handle) override;
+
+ // Obsolete and Deprecated methods.
+ void DidStartNavigationToPendingEntry(const GURL& url,
+ ReloadType reload_type) override;
void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,
const GURL& validated_url,
bool is_error_page) override;
@@ -62,6 +59,17 @@ class WebContentsObserverProxy : public WebContentsObserver {
RenderFrameHost* render_frame_host,
const GURL& url,
ui::PageTransition transition_type) override;
+ void DidFailProvisionalLoad(RenderFrameHost* render_frame_host,
+ const GURL& validated_url,
+ int error_code,
+ const base::string16& error_description,
+ bool was_ignored_by_handler) override;
+ void DidNavigateMainFrame(const LoadCommittedDetails& details,
+ const FrameNavigateParams& params) override;
+ void DidNavigateAnyFrame(RenderFrameHost* render_frame_host,
+ const LoadCommittedDetails& details,
+ const FrameNavigateParams& params) override;
+
void DidFinishLoad(RenderFrameHost* render_frame_host,
const GURL& validated_url) override;
void DocumentLoadedInFrame(RenderFrameHost* render_frame_host) override;
@@ -71,9 +79,6 @@ class WebContentsObserverProxy : public WebContentsObserver {
void DidAttachInterstitialPage() override;
void DidDetachInterstitialPage() override;
void DidChangeThemeColor(SkColor color) override;
- void DidStartNavigationToPendingEntry(
- const GURL& url,
- ReloadType reload_type) override;
void SetToBaseURLForDataURLIfNeeded(std::string* url);
void DidFailLoadInternal(bool is_provisional_load,

Powered by Google App Engine
This is Rietveld 408576698