Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java

Issue 2598163002: WebContentsObserver update for PlzNavigate methods (Closed)
Patch Set: Revert back a state CHECK Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
index dde1407799026c24823577eb68948f6a91dd86bd..bfc180b1941402c755a281cfc3b4d13a3da3f6fa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
@@ -440,9 +440,8 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
return new WebContentsObserver(webContents) {
@Override
- public void didStartProvisionalLoadForFrame(long frameId, long parentFrameId,
- boolean isMainFrame, String validatedUrl, boolean isErrorPage) {
- if (!isMainFrame) return;
+ public void didStartNavigation(String url, boolean isInMainFrame, boolean isErrorPage) {
+ if (!isInMainFrame) return;
// If there is a navigation in the current tab, hide the bar. It will show again
// once the distillability test is successful.
if (readerTabId == mTabModelSelector.getCurrentTabId()) {
@@ -453,20 +452,19 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
ReaderModeTabInfo tabInfo = mTabStatusMap.get(readerTabId);
if (tabInfo == null) return;
- tabInfo.setUrl(validatedUrl);
- if (DomDistillerUrlUtils.isDistilledPage(validatedUrl)) {
+ tabInfo.setUrl(url);
+ if (DomDistillerUrlUtils.isDistilledPage(url)) {
tabInfo.setStatus(STARTED);
- mReaderModePageUrl = validatedUrl;
+ mReaderModePageUrl = url;
}
}
@Override
- public void didNavigateMainFrame(String url, String baseUrl,
- boolean isNavigationToDifferentPage, boolean isNavigationInPage,
- int statusCode) {
+ public void didFinishNavigation(String url, boolean isInMainFrame, boolean isErrorPage,
+ boolean hasCommitted, boolean isSamePage, boolean isReload) {
// TODO(cjhopman): This should possibly ignore navigations that replace the entry
// (like those from history.replaceState()).
- if (isNavigationInPage) return;
+ if (isSamePage) return;
if (DomDistillerUrlUtils.isDistilledPage(url)) return;
// Make sure the tab was not destroyed.
@@ -474,9 +472,8 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
if (tabInfo == null) return;
tabInfo.setStatus(POSSIBLE);
- if (!TextUtils.equals(url,
- DomDistillerUrlUtils.getOriginalUrlFromDistillerUrl(
- mReaderModePageUrl))) {
+ if (!TextUtils.equals(url, DomDistillerUrlUtils.getOriginalUrlFromDistillerUrl(
+ mReaderModePageUrl))) {
tabInfo.setStatus(NOT_POSSIBLE);
mIsUmaRecorded = false;
}

Powered by Google App Engine
This is Rietveld 408576698