Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2598163002: WebContentsObserver update for PlzNavigate methods (Closed)
Patch Set: AW fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/navigation_handle_impl.h" 5 #include "content/browser/frame_host/navigation_handle_impl.h"
6 6
7 #include "base/debug/dump_without_crashing.h" 7 #include "base/debug/dump_without_crashing.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "content/browser/appcache/appcache_navigation_handle.h" 9 #include "content/browser/appcache/appcache_navigation_handle.h"
10 #include "content/browser/appcache/appcache_service_impl.h" 10 #include "content/browser/appcache/appcache_service_impl.h"
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 CHECK_NE(INITIAL, state_) 211 CHECK_NE(INITIAL, state_)
212 << "This accessor should not be called before the request is started."; 212 << "This accessor should not be called before the request is started.";
213 return is_external_protocol_; 213 return is_external_protocol_;
214 } 214 }
215 215
216 net::Error NavigationHandleImpl::GetNetErrorCode() { 216 net::Error NavigationHandleImpl::GetNetErrorCode() {
217 return net_error_code_; 217 return net_error_code_;
218 } 218 }
219 219
220 RenderFrameHostImpl* NavigationHandleImpl::GetRenderFrameHost() { 220 RenderFrameHostImpl* NavigationHandleImpl::GetRenderFrameHost() {
221 // TODO(mkwst): Change this to check against 'READY_TO_COMMIT' once 221 CHECK_GE(state_, READY_TO_COMMIT)
222 // ReadyToCommitNavigation is available whether or not PlzNavigate is
223 // enabled. https://crbug.com/621856
Ted C 2016/12/28 20:00:21 ah, the bug got fixed so you're just resolving the
224 CHECK_GE(state_, WILL_PROCESS_RESPONSE)
225 << "This accessor should only be called after a response has been " 222 << "This accessor should only be called after a response has been "
226 "delivered for processing."; 223 "delivered for processing.";
227 return render_frame_host_; 224 return render_frame_host_;
228 } 225 }
229 226
230 bool NavigationHandleImpl::IsSamePage() { 227 bool NavigationHandleImpl::IsSamePage() {
231 return is_same_page_; 228 return is_same_page_;
232 } 229 }
233 230
234 const net::HttpResponseHeaders* NavigationHandleImpl::GetResponseHeaders() { 231 const net::HttpResponseHeaders* NavigationHandleImpl::GetResponseHeaders() {
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
794 throttles_.push_back(std::move(ancestor_throttle)); 791 throttles_.push_back(std::move(ancestor_throttle));
795 792
796 if (throttles_to_register.size() > 0) { 793 if (throttles_to_register.size() > 0) {
797 throttles_.insert(throttles_.begin(), throttles_to_register.begin(), 794 throttles_.insert(throttles_.begin(), throttles_to_register.begin(),
798 throttles_to_register.end()); 795 throttles_to_register.end());
799 throttles_to_register.weak_clear(); 796 throttles_to_register.weak_clear();
800 } 797 }
801 } 798 }
802 799
803 } // namespace content 800 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698