Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: extensions/renderer/api_signature.h

Issue 2598123002: [Extensions Bindings] Add support for updateArgumentsPreValidate (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_bindings_system_unittest.cc ('k') | extensions/renderer/api_signature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_signature.h
diff --git a/extensions/renderer/api_signature.h b/extensions/renderer/api_signature.h
index 0e1451d73d48566015c26c800fe76d78e4ef568f..42d25df7e9b570fb93491c669a2a4262ac41fa31 100644
--- a/extensions/renderer/api_signature.h
+++ b/extensions/renderer/api_signature.h
@@ -17,10 +17,6 @@ class Value;
class ListValue;
}
-namespace gin {
-class Arguments;
-}
-
namespace extensions {
// A representation of the expected signature for an API method, along with the
@@ -35,7 +31,8 @@ class APISignature {
// from the list of arguments passed in because it will include null-filled
// optional arguments.
// Returns true if the arguments were successfully parsed and converted.
- bool ParseArgumentsToV8(gin::Arguments* arguments,
+ bool ParseArgumentsToV8(v8::Local<v8::Context> context,
+ const std::vector<v8::Local<v8::Value>>& arguments,
const ArgumentSpec::RefMap& type_refs,
std::vector<v8::Local<v8::Value>>* args_out,
std::string* error) const;
@@ -44,7 +41,8 @@ class APISignature {
// Returns true if the arguments were successfully parsed and converted, and
// populates |args_out| and |callback_out| with the JSON arguments and
// callback values, respectively. On failure, returns false populates |error|.
- bool ParseArgumentsToJSON(gin::Arguments* arguments,
+ bool ParseArgumentsToJSON(v8::Local<v8::Context> context,
+ const std::vector<v8::Local<v8::Value>>& arguments,
const ArgumentSpec::RefMap& type_refs,
std::unique_ptr<base::ListValue>* args_out,
v8::Local<v8::Function>* callback_out,
« no previous file with comments | « extensions/renderer/api_bindings_system_unittest.cc ('k') | extensions/renderer/api_signature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698