[Extensions Bindings] Add support for updateArgumentsPreValidate

extensions/renderer/native_extension_bindings_system_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/native_extension_bindings_system.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "components/crx_file/id_util.h"
@@ skipping 267 matching lines @@
 TEST_F(NativeExtensionBindingsSystemUnittest, TestBridgingToJSCustomBindings) {
   // Custom binding code. This basically utilizes the interface in binding.js in
   // order to test backwards compatibility.
   const char kCustomBinding[] =
       "apiBridge.registerCustomHook((api, extensionId, contextType) => {\n"
       "  api.apiFunctions.setHandleRequest('queryState',\n"
       "                                    (time, callback) => {\n"
       "    this.timeArg = time;\n"
       "    callback('active');\n"
       "  });\n"
+      "  api.apiFunctions.setUpdateArgumentsPreValidate(\n"
+      "      'setDetectionInterval', (interval) => {\n"
+      "    this.intervalArg = interval;\n"
+      "    return [50];\n"
+      "  });\n"
       "  this.hookedExtensionId = extensionId;\n"
       "  this.hookedContextType = contextType;\n"
       "  api.compiledApi.hookedApiProperty = 'someProperty';\n"
       "});\n";
 
   source_map()->RegisterModule("idle", kCustomBinding);
 
   scoped_refptr<Extension> extension = CreateExtension("foo", {"idle"});
   RegisterExtension(extension->id());
 
@@ skipping 36 matching lines @@
             GetStringPropertyFromObject(idle_api.As<v8::Object>(), context,
                                         "hookedApiProperty"));
 
   // Next, we need to check two pieces: first, that the custom handler was
   // called with the proper arguments....
   EXPECT_EQ("30", GetStringPropertyFromObject(global, context, "timeArg"));
 
   // ...and second, that the callback was called with the proper result.
   EXPECT_EQ("\"active\"",
             GetStringPropertyFromObject(global, context, "responseState"));
+
+  // Test the updateArgumentsPreValidate hook.
+  {
+    // Call the function correctly.
+    const char kCallIdleSetInterval[] =
+        "(function() {\n"
+        "  chrome.idle.setDetectionInterval(20);\n"
+        "});";
+
+    v8::Local<v8::Function> call_idle_set_interval =
+        FunctionFromString(context, kCallIdleSetInterval);
+    RunFunctionOnGlobal(call_idle_set_interval, context, 0, nullptr);
+  }
+
+  // Since we don't have a custom request handler, the hook should have only
+  // updated the arguments. The request then should have gone to the browser
+  // normally.
+  EXPECT_EQ("20", GetStringPropertyFromObject(global, context, "intervalArg"));
+  EXPECT_EQ(extension->id(), last_params().extension_id);
+  EXPECT_EQ("idle.setDetectionInterval", last_params().name);
+  EXPECT_EQ(extension->url(), last_params().source_url);
+  EXPECT_FALSE(last_params().has_callback);
+  EXPECT_TRUE(
+      last_params().arguments.Equals(ListValueFromString("[50]").get()));
 }
 
 }  // namespace extensions