components/autofill/core/browser/webdata/autocomplete_sync_bridge.h - Issue 2598113002: [Sync] Use a proto to generate AutofillSyncStorageKey's storage keys.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/core/browser/webdata/autocomplete_sync_bridge.h

Issue 2598113002: [Sync] Use a proto to generate AutofillSyncStorageKey's storage keys. (Closed)

Patch Set: Updated for mathp's comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/autofill/core/browser/proto/autofill_sync.proto ('k') | components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOCOMPLETE_SYNC_BRIDGE_H_	5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOCOMPLETE_SYNC_BRIDGE_H_

6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOCOMPLETE_SYNC_BRIDGE_H_	6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOCOMPLETE_SYNC_BRIDGE_H_

7	7

	8 #include <memory>

	9 #include <string>

	10

8 #include "base/scoped_observer.h"	11 #include "base/scoped_observer.h"

9 #include "base/supports_user_data.h"	12 #include "base/supports_user_data.h"

10 #include "base/threading/non_thread_safe.h"	13 #include "base/threading/non_thread_safe.h"

11 #include "components/autofill/core/browser/webdata/autofill_change.h"	14 #include "components/autofill/core/browser/webdata/autofill_change.h"

12 #include "components/autofill/core/browser/webdata/autofill_webdata_service_obse rver.h"	15 #include "components/autofill/core/browser/webdata/autofill_webdata_service_obse rver.h"

13 #include "components/sync/model/metadata_change_list.h"	16 #include "components/sync/model/metadata_change_list.h"

14 #include "components/sync/model/model_type_sync_bridge.h"	17 #include "components/sync/model/model_type_sync_bridge.h"

15	18

16 namespace syncer {	19 namespace syncer {

17 class SyncError;	20 class SyncError;

(...skipping 65 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
83 // SupportsUserData, so it's guaranteed to outlive \|this\|.	86 // SupportsUserData, so it's guaranteed to outlive \|this\|.

84 AutofillWebDataBackend* const web_data_backend_;	87 AutofillWebDataBackend* const web_data_backend_;

85	88

86 ScopedObserver<AutofillWebDataBackend, AutocompleteSyncBridge>	89 ScopedObserver<AutofillWebDataBackend, AutocompleteSyncBridge>

87 scoped_observer_;	90 scoped_observer_;

88 };	91 };

89	92

90 } // namespace autofill	93 } // namespace autofill

91	94

92 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOCOMPLETE_SYNC_BRIDGE_H_	95 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOCOMPLETE_SYNC_BRIDGE_H_

OLD	NEW